From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vitaly Kuznetsov Subject: [PATCH net-next 3/4] hv_netvsc: reset net_device_ctx->nvdev with rcu_assign_pointer() Date: Tue, 31 Oct 2017 14:42:03 +0100 Message-ID: <20171031134204.15287-4-vkuznets@redhat.com> References: <20171031134204.15287-1-vkuznets@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: devel@linuxdriverproject.org, Haiyang Zhang , Stephen Hemminger , linux-kernel@vger.kernel.org To: netdev@vger.kernel.org Return-path: In-Reply-To: <20171031134204.15287-1-vkuznets@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" List-Id: netdev.vger.kernel.org RCU_INIT_POINTER() is not suitable here as it doesn't give us ordering guarantees (see the comment in rcupdate.h). This is also not a hotpath. Signed-off-by: Vitaly Kuznetsov --- drivers/net/hyperv/netvsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c index bfc79698b8f4..12efb3e34775 100644 --- a/drivers/net/hyperv/netvsc.c +++ b/drivers/net/hyperv/netvsc.c @@ -560,7 +560,7 @@ void netvsc_device_remove(struct hv_device *device) netvsc_revoke_buf(device, net_device); - RCU_INIT_POINTER(net_device_ctx->nvdev, NULL); + rcu_assign_pointer(net_device_ctx->nvdev, NULL); /* * At this point, no one should be accessing net_device -- 2.13.6