From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Egerer <thomas.egerer@secunet.com>
Cc: <netdev@vger.kernel.org>
Subject: Re: [PATCH iproute2 3/3] xfrm_{state,policy}: Allow to deleteall polices/states with marks
Date: Tue, 31 Oct 2017 18:13:59 +0100 [thread overview]
Message-ID: <20171031181359.5b868f1a@shemminger-XPS-13-9360> (raw)
In-Reply-To: <97621e2c-30e3-aba3-ed5a-71241d94ec26@secunet.com>
On Mon, 30 Oct 2017 19:11:46 +0100
Thomas Egerer <thomas.egerer@secunet.com> wrote:
>
> + if (tb[XFRMA_MARK]) {
> + int r = addattr_l(new_n, xb->size, XFRMA_MARK,
> + (void *)RTA_DATA(tb[XFRMA_MARK]), tb[XFRMA_MARK]->rta_len);
Since addattr_l already uses const void * for the attribute argument,
the cast here is unnecessary. Also try and break long lines if possible.
Also, you should probably be using RTA_PAYLOAD() rather than dereferncing rta_len
here.
next prev parent reply other threads:[~2017-10-31 17:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-30 18:11 [PATCH iproute2 3/3] xfrm_{state,policy}: Allow to deleteall polices/states with marks Thomas Egerer
2017-10-31 17:13 ` Stephen Hemminger [this message]
2017-11-01 9:52 ` Thomas Egerer
2017-11-01 21:05 ` Stephen Hemminger
2017-11-02 13:13 ` [PATCH iproute2-resend 0/3] *** SUBJECT HERE *** Thomas Egerer
2017-11-07 2:14 ` Stephen Hemminger
2017-11-02 13:13 ` [PATCH iproute2-resend 1/3] xfrm_policy: Add filter option for socket policies Thomas Egerer
2017-11-02 13:13 ` [PATCH iproute2-resend 2/3] xfrm_policy: Do not attempt to deleteall a socket policy Thomas Egerer
2017-11-02 13:13 ` [PATCH iproute2-resend 3/3] xfrm_{state,policy}: Allow to deleteall polices/states with marks Thomas Egerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171031181359.5b868f1a@shemminger-XPS-13-9360 \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=thomas.egerer@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox