From: Stephen Hemminger <stephen@networkplumber.org>
To: Amritha Nambiar <amritha.nambiar@intel.com>
Cc: netdev@vger.kernel.org, alexander.h.duyck@intel.com,
jiri@resnulli.us, jhs@mojatatu.com, alexander.duyck@gmail.com,
xiyou.wangcong@gmail.com
Subject: Re: [iproute2 PATCH] tc/mqprio: Offload mode and shaper options in mqprio
Date: Tue, 31 Oct 2017 18:20:46 +0100 [thread overview]
Message-ID: <20171031182046.23eda44c@shemminger-XPS-13-9360> (raw)
In-Reply-To: <150906256227.24207.1663946225760686391.stgit@anamdev.jf.intel.com>
On Thu, 26 Oct 2017 17:02:42 -0700
Amritha Nambiar <amritha.nambiar@intel.com> wrote:
> This patch was previously submitted as RFC. Submitting this as
> non-RFC now that the tc/mqprio changes are accepted in net-next.
>
> Adds new mqprio options for 'mode' and 'shaper'. The mode
> option can take values for offload modes such as 'dcb' (default),
> 'channel' with the 'hw' option set to 1. The new 'channel' mode
> supports offloading TCs and other queue configurations. The
> 'shaper' option is to support HW shapers ('dcb' default) and
> takes the value 'bw_rlimit' for bandwidth rate limiting. The
> parameters to the bw_rlimit shaper are minimum and maximum
> bandwidth rates. New HW shapers in future can be supported
> through the shaper attribute.
>
> # tc qdisc add dev eth0 root mqprio num_tc 2 map 0 0 0 0 1 1 1 1\
> queues 4@0 4@4 hw 1 mode channel shaper bw_rlimit\
> min_rate 1Gbit 2Gbit max_rate 4Gbit 5Gbit
>
> # tc qdisc show dev eth0
>
> qdisc mqprio 804a: root tc 2 map 0 0 0 0 1 1 1 1 0 0 0 0 0 0 0 0
> queues:(0:3) (4:7)
> mode:channel
> shaper:bw_rlimit min_rate:1Gbit 2Gbit max_rate:4Gbit 5Gbit
>
> Signed-off-by: Amritha Nambiar <amritha.nambiar@intel.com>
Please build test your patch with compiler checks enabled....
CC q_mqprio.o
In file included from /usr/include/string.h:635:0,
from q_mqprio.c:20:
In function ‘memcpy’,
inlined from ‘mqprio_print_opt’ at q_mqprio.c:237:2:
/usr/include/x86_64-linux-gnu/bits/string3.h:53:10: warning: call to __builtin___memcpy_chk will always overflow destination buffer
return __builtin___memcpy_chk (__dest, __src, __len, __bos0 (__dest));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
next prev parent reply other threads:[~2017-10-31 17:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-27 0:02 [iproute2 PATCH] tc/mqprio: Offload mode and shaper options in mqprio Amritha Nambiar
2017-10-31 17:20 ` Stephen Hemminger [this message]
2017-11-01 7:40 ` Nambiar, Amritha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171031182046.23eda44c@shemminger-XPS-13-9360 \
--to=stephen@networkplumber.org \
--cc=alexander.duyck@gmail.com \
--cc=alexander.h.duyck@intel.com \
--cc=amritha.nambiar@intel.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox