* [PATCH][V2] net: ethernet: slicoss: remove redundant initialization of idx
@ 2017-10-31 10:08 Colin King
2017-10-31 11:37 ` Lino Sanfilippo
2017-11-01 12:20 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2017-10-31 10:08 UTC (permalink / raw)
To: Lino Sanfilippo, netdev; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Variable idx is being initialized and later on over-written by
a new value in a do-loop without the initial value ever being
read. Hence the initializion is redundant and can be removed.
Cleans up clang warning:
drivers/net/ethernet/alacritech/slicoss.c:358:15: warning: Value
stored to 'idx' during its initialization is never read
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/ethernet/alacritech/slicoss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/alacritech/slicoss.c b/drivers/net/ethernet/alacritech/slicoss.c
index 15a8096c60df..0b60921c392f 100644
--- a/drivers/net/ethernet/alacritech/slicoss.c
+++ b/drivers/net/ethernet/alacritech/slicoss.c
@@ -355,10 +355,10 @@ static void slic_xmit_complete(struct slic_device *sdev)
{
struct slic_tx_queue *txq = &sdev->txq;
struct net_device *dev = sdev->netdev;
- unsigned int idx = txq->done_idx;
struct slic_tx_buffer *buff;
unsigned int frames = 0;
unsigned int bytes = 0;
+ unsigned int idx;
/* Limit processing to SLIC_MAX_TX_COMPLETIONS frames to avoid that new
* completions during processing keeps the loop running endlessly.
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH][V2] net: ethernet: slicoss: remove redundant initialization of idx
2017-10-31 10:08 [PATCH][V2] net: ethernet: slicoss: remove redundant initialization of idx Colin King
@ 2017-10-31 11:37 ` Lino Sanfilippo
2017-11-01 12:20 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Lino Sanfilippo @ 2017-10-31 11:37 UTC (permalink / raw)
To: Colin King, netdev; +Cc: kernel-janitors, linux-kernel
On 31.10.2017 11:08, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable idx is being initialized and later on over-written by
> a new value in a do-loop without the initial value ever being
> read. Hence the initializion is redundant and can be removed.
> Cleans up clang warning:
>
> drivers/net/ethernet/alacritech/slicoss.c:358:15: warning: Value
> stored to 'idx' during its initialization is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/ethernet/alacritech/slicoss.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/alacritech/slicoss.c b/drivers/net/ethernet/alacritech/slicoss.c
> index 15a8096c60df..0b60921c392f 100644
> --- a/drivers/net/ethernet/alacritech/slicoss.c
> +++ b/drivers/net/ethernet/alacritech/slicoss.c
> @@ -355,10 +355,10 @@ static void slic_xmit_complete(struct slic_device *sdev)
> {
> struct slic_tx_queue *txq = &sdev->txq;
> struct net_device *dev = sdev->netdev;
> - unsigned int idx = txq->done_idx;
> struct slic_tx_buffer *buff;
> unsigned int frames = 0;
> unsigned int bytes = 0;
> + unsigned int idx;
>
> /* Limit processing to SLIC_MAX_TX_COMPLETIONS frames to avoid that new
> * completions during processing keeps the loop running endlessly.
>
Acked-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Regards,
Lino
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH][V2] net: ethernet: slicoss: remove redundant initialization of idx
2017-10-31 10:08 [PATCH][V2] net: ethernet: slicoss: remove redundant initialization of idx Colin King
2017-10-31 11:37 ` Lino Sanfilippo
@ 2017-11-01 12:20 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-11-01 12:20 UTC (permalink / raw)
To: colin.king; +Cc: LinoSanfilippo, netdev, kernel-janitors, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Tue, 31 Oct 2017 10:08:23 +0000
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable idx is being initialized and later on over-written by
> a new value in a do-loop without the initial value ever being
> read. Hence the initializion is redundant and can be removed.
> Cleans up clang warning:
>
> drivers/net/ethernet/alacritech/slicoss.c:358:15: warning: Value
> stored to 'idx' during its initialization is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied to net-next.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-01 12:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-31 10:08 [PATCH][V2] net: ethernet: slicoss: remove redundant initialization of idx Colin King
2017-10-31 11:37 ` Lino Sanfilippo
2017-11-01 12:20 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).