From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Barnhill <0xeffeff@gmail.com> Subject: [PATCH] net: vrf: correct FRA_L3MDEV encode type Date: Wed, 1 Nov 2017 01:24:14 +0000 Message-ID: <20171101012414.1637-1-0xeffeff@gmail.com> Cc: Jeff Barnhill <0xeffeff@gmail.com> To: netdev@vger.kernel.org Return-path: Received: from mail-qt0-f195.google.com ([209.85.216.195]:43942 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752175AbdKABYZ (ORCPT ); Tue, 31 Oct 2017 21:24:25 -0400 Received: by mail-qt0-f195.google.com with SMTP id j58so1038819qtj.0 for ; Tue, 31 Oct 2017 18:24:25 -0700 (PDT) Sender: netdev-owner@vger.kernel.org List-ID: FRA_L3MDEV is defined as U8, but is being added as a U32 attribute. On big endian architecture, this results in the l3mdev entry not being added to the FIB rules. Fixes: 1aa6c4f6b8cd8 ("net: vrf: Add l3mdev rules on first device create") --- drivers/net/vrf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/vrf.c b/drivers/net/vrf.c index 9b243e6f3008..7dc3bcac3506 100644 --- a/drivers/net/vrf.c +++ b/drivers/net/vrf.c @@ -1165,7 +1165,7 @@ static int vrf_fib_rule(const struct net_device *dev, __u8 family, bool add_it) frh->family = family; frh->action = FR_ACT_TO_TBL; - if (nla_put_u32(skb, FRA_L3MDEV, 1)) + if (nla_put_u8(skb, FRA_L3MDEV, 1)) goto nla_put_failure; if (nla_put_u32(skb, FRA_PRIORITY, FIB_RULE_PREF)) -- 2.14.1