From: Andrew Lunn <andrew@lunn.ch>
To: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] net: phy: leds: Add support for "link" trigger
Date: Wed, 1 Nov 2017 13:16:11 +0100 [thread overview]
Message-ID: <20171101121611.GD12680@lunn.ch> (raw)
In-Reply-To: <52ce25a6-8d6b-039d-ca08-90595eb9ee72@maciej.szmigiero.name>
> @@ -123,6 +153,10 @@ int phy_led_triggers_register(struct phy_device *phy)
> while (i--)
> phy_led_trigger_unregister(&phy->phy_led_triggers[i]);
> devm_kfree(&phy->mdio.dev, phy->phy_led_triggers);
> +out_unreg_link:
> + phy_led_trigger_unregister(phy->led_link_trigger);
> +out_free_link:
> + devm_kfree(&phy->mdio.dev, phy->led_link_trigger);
Hi Maciej
The point of the devm_ API is that you don't need to worry about
freeing the memory. The core will do it, when the driver is removed.
I guess you are just copying the code above, which i would also say is
unnecessary.
Andrew
next prev parent reply other threads:[~2017-11-01 12:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 11:56 [PATCH v2] net: phy: leds: Add support for "link" trigger Maciej S. Szmigiero
2017-11-01 12:16 ` Andrew Lunn [this message]
2017-11-01 12:21 ` Maciej S. Szmigiero
2017-11-01 12:31 ` Andrew Lunn
2017-11-01 12:33 ` Maciej S. Szmigiero
2017-11-01 23:49 ` Maciej S. Szmigiero
2017-11-02 0:14 ` Andrew Lunn
2017-11-01 12:37 ` Andrew Lunn
2017-11-01 12:43 ` Maciej S. Szmigiero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171101121611.GD12680@lunn.ch \
--to=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@maciej.szmigiero.name \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).