From: David Miller <davem@davemloft.net>
To: colin.king@canonical.com
Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com,
linyunsheng@huawei.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: hns3: remove a couple of redundant assignments
Date: Thu, 02 Nov 2017 15:54:11 +0900 (KST) [thread overview]
Message-ID: <20171102.155411.1611979100337438252.davem@davemloft.net> (raw)
In-Reply-To: <20171101101715.17617-1-colin.king@canonical.com>
From: Colin King <colin.king@canonical.com>
Date: Wed, 1 Nov 2017 10:17:15 +0000
> From: Colin Ian King <colin.king@canonical.com>
>
> The assignment to kinfo is redundant as this is a duplicate of
> the initialiation of kinfo a few lines earlier, so it can be
> removed. The assignment to v_tc_info is never read, so this
> variable is redundant and can be removed completely. Cleans
> up two clang warnings:
>
> drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c:433:34:
> warning: Value stored to 'kinfo' during its initialization is never read
> drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c:775:3:
> warning: Value stored to 'v_tc_info' is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
prev parent reply other threads:[~2017-11-02 6:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-01 10:17 [PATCH] net: hns3: remove a couple of redundant assignments Colin King
2017-11-02 6:54 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171102.155411.1611979100337438252.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).