netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: khlebnikov@yandex-team.ru
Cc: netdev@vger.kernel.org, brakmo@fb.com, kuznet@ms2.inr.ac.ru,
	yoshfuji@linux-ipv6.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tcp_nv: fix division by zero in tcpnv_acked()
Date: Thu, 02 Nov 2017 16:17:55 +0900 (KST)	[thread overview]
Message-ID: <20171102.161755.1469652396797608567.davem@davemloft.net> (raw)
In-Reply-To: <150954313588.153848.10192893966808917578.stgit@buzz>

From: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Date: Wed, 01 Nov 2017 16:32:15 +0300

> Average RTT could become zero. This happened in real life at least twice.
> This patch treats zero as 1us.
> 
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>

Applied and queued up for -stable, thank you.

Indeed, as others have mentioned, a cheaper divide should be used
but that is a separate issue from this fix and therefore should be
done in a separate patch.

Thanks again.

      parent reply	other threads:[~2017-11-02  7:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-01 13:32 [PATCH] tcp_nv: fix division by zero in tcpnv_acked() Konstantin Khlebnikov
2017-11-01 13:47 ` Lawrence Brakmo
2017-11-01 14:13   ` Stephen Hemminger
2017-11-01 14:17 ` Eric Dumazet
2017-11-02  7:17 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171102.161755.1469652396797608567.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=brakmo@fb.com \
    --cc=khlebnikov@yandex-team.ru \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).