From: Andrew Lunn <andrew@lunn.ch>
To: Egil Hjelmeland <privat@egil-hjelmeland.no>
Cc: vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com,
rafal@milecki.pl, stephen@networkplumber.org,
bridge@lists.linux-foundation.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: Define eth_stp_addr in linux/etherdevice.h
Date: Thu, 2 Nov 2017 13:53:05 +0100 [thread overview]
Message-ID: <20171102125305.GI4772@lunn.ch> (raw)
In-Reply-To: <20171102093648.4141-1-privat@egil-hjelmeland.no>
On Thu, Nov 02, 2017 at 10:36:48AM +0100, Egil Hjelmeland wrote:
> Why:
Please drop the Why.
> The lan9303 driver defines eth_stp_addr as a synonym to
> eth_reserved_addr_base to get the STP ethernet address 01:80:c2:00:00:00.
>
> eth_reserved_addr_base is also used to define the start of Bridge Reserved
> ethernet address range, which happen to be the STP address.
>
> br_dev_setup refer to eth_reserved_addr_base as a definition of STP
> address.
>
> Clean up by:
> - Move the eth_stp_addr definition to linux/etherdevice.h
> - Use eth_stp_addr instead of eth_reserved_addr_base in br_dev_setup.
>
> Signed-off-by: Egil Hjelmeland <privat@egil-hjelmeland.no>
I was thinking along the same lines when reviewing your lan9303 patch.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2017-11-02 12:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 9:36 [PATCH net-next] net: Define eth_stp_addr in linux/etherdevice.h Egil Hjelmeland
2017-11-02 12:53 ` Andrew Lunn [this message]
2017-11-03 5:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171102125305.GI4772@lunn.ch \
--to=andrew@lunn.ch \
--cc=bridge@lists.linux-foundation.org \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=privat@egil-hjelmeland.no \
--cc=rafal@milecki.pl \
--cc=stephen@networkplumber.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).