From: Florian Westphal <fw@strlen.de>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: syzbot
<bot+e52a2ae091b628f72765583c9faedc961c83b7e7@syzkaller.appspotmail.com>,
David Miller <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
LKML <linux-kernel@vger.kernel.org>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
syzkaller-bugs@googlegroups.com,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
Subject: Re: suspicious RCU usage at ./include/linux/inetdevice.h:LINE
Date: Thu, 2 Nov 2017 20:06:31 +0100 [thread overview]
Message-ID: <20171102190631.GD9424@breakpoint.cc> (raw)
In-Reply-To: <CAM_iQpV-kXrXHsoZWuVzh0VBAQp7XbuWuNZJV7TKDOc2rzm01g@mail.gmail.com>
Cong Wang <xiyou.wangcong@gmail.com> wrote:
> > CPU: 0 PID: 23859 Comm: syz-executor2 Not tainted 4.14.0-rc5+ #140
> > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS
> > Google 01/01/2011
> > Call Trace:
> > __dump_stack lib/dump_stack.c:16 [inline]
> > dump_stack+0x194/0x257 lib/dump_stack.c:52
> > lockdep_rcu_suspicious+0x123/0x170 kernel/locking/lockdep.c:4665
> > __in_dev_get_rtnl include/linux/inetdevice.h:230 [inline]
> > fib_dump_info+0x1136/0x13d0 net/ipv4/fib_semantics.c:1377
> > inet_rtm_getroute+0xf97/0x2d70 net/ipv4/route.c:2785
>
> This is introduced by:
>
> commit 394f51abb3d04f33fb798f04b16ae6b0491ea4ec
> Author: Florian Westphal <fw@strlen.de>
> Date: Tue Aug 15 16:34:44 2017 +0200
>
> ipv4: route: set ipv4 RTM_GETROUTE to not use rtnl
>
> Signed-off-by: Florian Westphal <fw@strlen.de>
> Signed-off-by: David S. Miller <davem@davemloft.net>
>
> Looks like we need a wrapper for rcu_dereference_protected(dev->ip_ptr).
Yes, thats the alternative to
https://patchwork.ozlabs.org/patch/833401/
which switches to _rcu version.
next prev parent reply other threads:[~2017-11-02 19:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 10:53 suspicious RCU usage at ./include/linux/inetdevice.h:LINE syzbot
2017-11-02 15:02 ` [PATCH net] fib: fib_dump_info can no longer use __in_dev_get_rtnl Florian Westphal
2017-11-03 5:28 ` David Miller
2017-11-02 18:56 ` suspicious RCU usage at ./include/linux/inetdevice.h:LINE Cong Wang
2017-11-02 19:06 ` Florian Westphal [this message]
2017-11-02 20:55 ` Cong Wang
2018-01-31 0:43 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171102190631.GD9424@breakpoint.cc \
--to=fw@strlen.de \
--cc=bot+e52a2ae091b628f72765583c9faedc961c83b7e7@syzkaller.appspotmail.com \
--cc=davem@davemloft.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=syzkaller-bugs@googlegroups.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).