From: Charlie Sale <chucks.8090@gmail.com>
To: pablo@netfilter.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Charlie Sale <chucks.8090@gmail.com>
Subject: [PATCH] Net: netfilter: Moved vmalloc call to kmalloc call
Date: Thu, 2 Nov 2017 19:17:27 -0400 [thread overview]
Message-ID: <20171102231727.12610-1-chucks.8090@gmail.com> (raw)
Fixed FIXME comment in code my changing a vmalloc call
to a kmalloc call. Thought it would be a good place to
start for a first patch.
Signed-off-by: Charlie Sale <chucks.8090@gmail.com>
---
net/netfilter/xt_hashlimit.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/netfilter/xt_hashlimit.c b/net/netfilter/xt_hashlimit.c
index 5da8746f7b88..4eab1befe03c 100644
--- a/net/netfilter/xt_hashlimit.c
+++ b/net/netfilter/xt_hashlimit.c
@@ -286,9 +286,9 @@ static int htable_create(struct net *net, struct hashlimit_cfg3 *cfg,
if (size < 16)
size = 16;
}
- /* FIXME: don't use vmalloc() here or anywhere else -HW */
- hinfo = vmalloc(sizeof(struct xt_hashlimit_htable) +
- sizeof(struct hlist_head) * size);
+
+ hinfo = kmalloc(sizeof(*hinfo) +
+ sizeof(struct hlist_head) * size, GPT_KERNEL);
if (hinfo == NULL)
return -ENOMEM;
*out_hinfo = hinfo;
--
2.13.6
next reply other threads:[~2017-11-02 23:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 23:17 Charlie Sale [this message]
2017-11-02 23:35 ` [PATCH] Net: netfilter: Moved vmalloc call to kmalloc call Florian Westphal
2017-11-03 0:59 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171102231727.12610-1-chucks.8090@gmail.com \
--to=chucks.8090@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).