netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Duyck <alexander.duyck@gmail.com>
To: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org
Subject: [jkirsher/next-queue PATCH 1/5] ixgbe: Fix interaction between SR-IOV and macvlan offload
Date: Thu, 02 Nov 2017 16:33:30 -0700	[thread overview]
Message-ID: <20171102233315.15146.95215.stgit@localhost.localdomain> (raw)
In-Reply-To: <20171102232857.15146.21583.stgit@localhost.localdomain>

From: Alexander Duyck <alexander.h.duyck@intel.com>

When SR-IOV was enabled the macvlan offload was configuring several filters
with the wrong pool value. This would result in the macvlan interfaces not
being able to receive traffic that had to pass over the physical interface.

To fix it wrap the pool argument in the VMDQ_P macro which will add the
necessary offset to get to the actual VMDq pool

Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
---
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
index 2d0232254a7a..69ef35d13c36 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
@@ -5426,10 +5426,11 @@ static int ixgbe_fwd_ring_up(struct net_device *vdev,
 		goto fwd_queue_err;
 
 	if (is_valid_ether_addr(vdev->dev_addr))
-		ixgbe_add_mac_filter(adapter, vdev->dev_addr, accel->pool);
+		ixgbe_add_mac_filter(adapter, vdev->dev_addr,
+				     VMDQ_P(accel->pool));
 
 	ixgbe_fwd_psrtype(accel);
-	ixgbe_macvlan_set_rx_mode(vdev, accel->pool, adapter);
+	ixgbe_macvlan_set_rx_mode(vdev, VMDQ_P(accel->pool), adapter);
 	return err;
 fwd_queue_err:
 	ixgbe_fwd_ring_down(vdev, accel);

  reply	other threads:[~2017-11-02 23:33 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-02 23:33 [jkirsher/next-queue PATCH 0/5] macvlan offload fixes Alexander Duyck
2017-11-02 23:33 ` Alexander Duyck [this message]
2017-11-02 23:33 ` [jkirsher/next-queue PATCH 2/5] fm10k: Fix VLAN configuration for macvlan offload Alexander Duyck
2017-11-03 17:05   ` [Intel-wired-lan] " Jesse Brandeburg
2017-11-08 22:05     ` Keller, Jacob E
2017-11-08 23:03       ` Alexander Duyck
2017-11-09  0:21         ` Keller, Jacob E
2017-11-09  0:32           ` Alexander Duyck
2017-11-09  1:26             ` Keller, Jacob E
2017-11-02 23:34 ` [jkirsher/next-queue PATCH 3/5] ixgbe: Fix handling of macvlan Tx offload Alexander Duyck
2017-11-03 16:30   ` [Intel-wired-lan] " Shannon Nelson
2017-11-03 18:18   ` Alexander Duyck
2017-11-02 23:34 ` [jkirsher/next-queue PATCH 4/5] dev: Clean-up __skb_tx_hash to match up with traffic class based configs Alexander Duyck
2017-11-02 23:34 ` [jkirsher/next-queue PATCH 5/5] dev: Cap number of queues even with accel_priv Alexander Duyck
2017-11-03 17:07   ` [Intel-wired-lan] " Jesse Brandeburg
2017-11-03 17:13 ` [Intel-wired-lan] [jkirsher/next-queue PATCH 0/5] macvlan offload fixes Shannon Nelson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171102233315.15146.95215.stgit@localhost.localdomain \
    --to=alexander.duyck@gmail.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).