netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Duyck <alexander.duyck@gmail.com>
To: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org
Subject: [jkirsher/next-queue PATCH 2/5] fm10k: Fix VLAN configuration for macvlan offload
Date: Thu, 02 Nov 2017 16:33:45 -0700	[thread overview]
Message-ID: <20171102233336.15146.31137.stgit@localhost.localdomain> (raw)
In-Reply-To: <20171102232857.15146.21583.stgit@localhost.localdomain>

From: Alexander Duyck <alexander.h.duyck@intel.com>

The fm10k driver didn't work correctly when macvlan offload was enabled.
Specifically what would occur is that we would see no unicast packets being
received. This was traced down to us not correctly configuring the default
VLAN ID for the port and defaulting to 0.

To correct this we either use the default ID provided by the switch or
simply use 1. With that we are able to pass and receive traffic without any
issues.

Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
---
 drivers/net/ethernet/intel/fm10k/fm10k_netdev.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c b/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c
index 81e4425f0529..1280127077de 100644
--- a/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c
+++ b/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c
@@ -1490,7 +1490,7 @@ static void *fm10k_dfwd_add_station(struct net_device *dev,
 		hw->mac.ops.update_xcast_mode(hw, glort,
 					      FM10K_XCAST_MODE_MULTI);
 		fm10k_queue_mac_request(interface, glort, sdev->dev_addr,
-					0, true);
+					hw->mac.default_vid ? : 1, true);
 	}
 
 	fm10k_mbx_unlock(interface);
@@ -1530,7 +1530,7 @@ static void fm10k_dfwd_del_station(struct net_device *dev, void *priv)
 		hw->mac.ops.update_xcast_mode(hw, glort,
 					      FM10K_XCAST_MODE_NONE);
 		fm10k_queue_mac_request(interface, glort, sdev->dev_addr,
-					0, false);
+					hw->mac.default_vid ? : 1, false);
 	}
 
 	fm10k_mbx_unlock(interface);

  parent reply	other threads:[~2017-11-02 23:33 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-02 23:33 [jkirsher/next-queue PATCH 0/5] macvlan offload fixes Alexander Duyck
2017-11-02 23:33 ` [jkirsher/next-queue PATCH 1/5] ixgbe: Fix interaction between SR-IOV and macvlan offload Alexander Duyck
2017-11-02 23:33 ` Alexander Duyck [this message]
2017-11-03 17:05   ` [Intel-wired-lan] [jkirsher/next-queue PATCH 2/5] fm10k: Fix VLAN configuration for " Jesse Brandeburg
2017-11-08 22:05     ` Keller, Jacob E
2017-11-08 23:03       ` Alexander Duyck
2017-11-09  0:21         ` Keller, Jacob E
2017-11-09  0:32           ` Alexander Duyck
2017-11-09  1:26             ` Keller, Jacob E
2017-11-02 23:34 ` [jkirsher/next-queue PATCH 3/5] ixgbe: Fix handling of macvlan Tx offload Alexander Duyck
2017-11-03 16:30   ` [Intel-wired-lan] " Shannon Nelson
2017-11-03 18:18   ` Alexander Duyck
2017-11-02 23:34 ` [jkirsher/next-queue PATCH 4/5] dev: Clean-up __skb_tx_hash to match up with traffic class based configs Alexander Duyck
2017-11-02 23:34 ` [jkirsher/next-queue PATCH 5/5] dev: Cap number of queues even with accel_priv Alexander Duyck
2017-11-03 17:07   ` [Intel-wired-lan] " Jesse Brandeburg
2017-11-03 17:13 ` [Intel-wired-lan] [jkirsher/next-queue PATCH 0/5] macvlan offload fixes Shannon Nelson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171102233336.15146.31137.stgit@localhost.localdomain \
    --to=alexander.duyck@gmail.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).