netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: tom@quantonium.net
Cc: netdev@vger.kernel.org, rohit@quantonium.net
Subject: Re: [PATCH v2 net-next] ipv6: Implement limits on Hop-by-Hop and Destination options
Date: Fri, 03 Nov 2017 10:11:08 +0900 (KST)	[thread overview]
Message-ID: <20171103.101108.660889899668900453.davem@davemloft.net> (raw)
In-Reply-To: <20171030211600.6491-1-tom@quantonium.net>

From: Tom Herbert <tom@quantonium.net>
Date: Mon, 30 Oct 2017 14:16:00 -0700

> RFC 8200 (IPv6) defines Hop-by-Hop options and Destination options
> extension headers. Both of these carry a list of TLVs which is
> only limited by the maximum length of the extension header (2048
> bytes). By the spec a host must process all the TLVs in these
> options, however these could be used as a fairly obvious
> denial of service attack. I think this could in fact be
> a significant DOS vector on the Internet, one mitigating
> factor might be that many FWs drop all packets with EH (and
> obviously this is only IPv6) so an Internet wide attack might not
> be so effective (yet!).
 ...
> This patch adds configurable limits to Destination and Hop-by-Hop
> options. There are three limits that may be set:
>   - Limit the number of options in a Hop-by-Hop or Destination options
>     extension header.
>   - Limit the byte length of a Hop-by-Hop or Destination options
>     extension header.
>   - Disallow unrecognized options in a Hop-by-Hop or Destination
>     options extension header.
> 
> The limits are set in corresponding sysctls:
> 
>   ipv6.sysctl.max_dst_opts_cnt
>   ipv6.sysctl.max_hbh_opts_cnt
>   ipv6.sysctl.max_dst_opts_len
>   ipv6.sysctl.max_hbh_opts_len
 ...
> Signed-off-by: Tom Herbert <tom@quantonium.net>

Applied to net-next, let's see how this goes.

Thanks.

      parent reply	other threads:[~2017-11-03  1:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-30 21:16 [PATCH v2 net-next] ipv6: Implement limits on Hop-by-Hop and Destination options Tom Herbert
2017-10-31  2:10 ` David Miller
2017-10-31  2:39   ` Tom Herbert
2017-10-31  2:52   ` Eric Dumazet
2017-11-03  1:11 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171103.101108.660889899668900453.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=rohit@quantonium.net \
    --cc=tom@quantonium.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).