From: David Miller <davem@davemloft.net>
To: vbhadram@nvidia.com
Cc: netdev@vger.kernel.org, peppe.cavallaro@st.com,
clabbe.montjoie@gmail.com, Joao.Pinto@synopsys.com
Subject: Re: [PATCH] stmmac: use of_property_read_u32 instead of read_u8
Date: Fri, 03 Nov 2017 14:15:25 +0900 (KST) [thread overview]
Message-ID: <20171103.141525.401018454583463624.davem@davemloft.net> (raw)
In-Reply-To: <1509607333-8864-1-git-send-email-vbhadram@nvidia.com>
From: Bhadram Varka <vbhadram@nvidia.com>
Date: Thu, 2 Nov 2017 12:52:13 +0530
> Numbers in DT are stored in “cells” which are 32-bits
> in size. of_property_read_u8 does not work properly
> because of endianness problem.
>
> This causes it to always return 0 with little-endian
> architectures.
>
> Fix it by using of_property_read_u32() OF API.
>
> Signed-off-by: Bhadram Varka <vbhadram@nvidia.com>
Applied, thank you.
prev parent reply other threads:[~2017-11-03 5:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 7:22 [PATCH] stmmac: use of_property_read_u32 instead of read_u8 Bhadram Varka
2017-11-03 5:15 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171103.141525.401018454583463624.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Joao.Pinto@synopsys.com \
--cc=clabbe.montjoie@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=vbhadram@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).