From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [patch net-next] net: sched: move block offload unbind after all chains are flushed Date: Fri, 03 Nov 2017 15:47:44 +0900 (KST) Message-ID: <20171103.154744.1648531780926119509.davem@davemloft.net> References: <20171102140701.1485-1-jiri@resnulli.us> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, mlxsw@mellanox.com, alexander.h.duyck@intel.com, kubakici@wp.pl To: jiri@resnulli.us Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:36642 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753623AbdKCGrt (ORCPT ); Fri, 3 Nov 2017 02:47:49 -0400 In-Reply-To: <20171102140701.1485-1-jiri@resnulli.us> Sender: netdev-owner@vger.kernel.org List-ID: From: Jiri Pirko Date: Thu, 2 Nov 2017 15:07:01 +0100 > From: Jiri Pirko > > Currently, the offload unbind is done before the chains are flushed. > That causes driver to unregister block callback before it can get all > the callback calls done during flush, leaving the offloaded tps inside > the HW. So fix the order to prevent this situation and restore the > original behaviour. > > Reported-by: Alexander Duyck > Reported-by: Jakub Kicinski > Signed-off-by: Jiri Pirko I'm pretty sure this was my fault during the merge, I had to pick whether to do it before or after the offload unbind and I picked the latter. Applied, thank you.