From: David Miller <davem@davemloft.net>
To: colin.king@canonical.com
Cc: ast@kernel.org, daniel@iogearbox.net, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, jiri@resnulli.us,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][net-next] net: sched: cls_bpf: use bitwise & rather than logical && on gen_flags
Date: Fri, 03 Nov 2017 15:55:01 +0900 (KST) [thread overview]
Message-ID: <20171103.155501.268373482338402451.davem@davemloft.net> (raw)
In-Reply-To: <20171102200412.16757-1-colin.king@canonical.com>
From: Colin King <colin.king@canonical.com>
Date: Thu, 2 Nov 2017 20:04:12 +0000
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently gen_flags is being operated on by a logical && operator rather
> than a bitwise & operator. This looks incorrect as these should be bit
> flag operations. Fix this.
>
> Detected by CoverityScan, CID#1460305 ("Logical vs. bitwise operator")
>
> Fixes: 3f7889c4c79b ("net: sched: cls_bpf: call block callbacks for offload)
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
prev parent reply other threads:[~2017-11-03 6:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 20:04 [PATCH][net-next] net: sched: cls_bpf: use bitwise & rather than logical && on gen_flags Colin King
2017-11-02 22:20 ` Daniel Borkmann
2017-11-03 6:55 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171103.155501.268373482338402451.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ast@kernel.org \
--cc=colin.king@canonical.com \
--cc=daniel@iogearbox.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).