From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH][net-next] net: sched: cls_bpf: use bitwise & rather than logical && on gen_flags Date: Fri, 03 Nov 2017 15:55:01 +0900 (KST) Message-ID: <20171103.155501.268373482338402451.davem@davemloft.net> References: <20171102200412.16757-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: ast@kernel.org, daniel@iogearbox.net, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org To: colin.king@canonical.com Return-path: In-Reply-To: <20171102200412.16757-1-colin.king@canonical.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Colin King Date: Thu, 2 Nov 2017 20:04:12 +0000 > From: Colin Ian King > > Currently gen_flags is being operated on by a logical && operator rather > than a bitwise & operator. This looks incorrect as these should be bit > flag operations. Fix this. > > Detected by CoverityScan, CID#1460305 ("Logical vs. bitwise operator") > > Fixes: 3f7889c4c79b ("net: sched: cls_bpf: call block callbacks for offload) > Signed-off-by: Colin Ian King Applied.