* [PATCH][net-next] net: sched: cls_bpf: use bitwise & rather than logical && on gen_flags
@ 2017-11-02 20:04 Colin King
2017-11-02 22:20 ` Daniel Borkmann
2017-11-03 6:55 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2017-11-02 20:04 UTC (permalink / raw)
To: Alexei Starovoitov, Daniel Borkmann, Jamal Hadi Salim, Cong Wang,
Jiri Pirko, David S . Miller, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Currently gen_flags is being operated on by a logical && operator rather
than a bitwise & operator. This looks incorrect as these should be bit
flag operations. Fix this.
Detected by CoverityScan, CID#1460305 ("Logical vs. bitwise operator")
Fixes: 3f7889c4c79b ("net: sched: cls_bpf: call block callbacks for offload)
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
net/sched/cls_bpf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sched/cls_bpf.c b/net/sched/cls_bpf.c
index 5f701c8670a2..bc3edde1b9d7 100644
--- a/net/sched/cls_bpf.c
+++ b/net/sched/cls_bpf.c
@@ -174,7 +174,7 @@ static int cls_bpf_offload_cmd(struct tcf_proto *tp, struct cls_bpf_prog *prog,
}
}
- if (addorrep && skip_sw && !(prog->gen_flags && TCA_CLS_FLAGS_IN_HW))
+ if (addorrep && skip_sw && !(prog->gen_flags & TCA_CLS_FLAGS_IN_HW))
return -EINVAL;
return 0;
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH][net-next] net: sched: cls_bpf: use bitwise & rather than logical && on gen_flags
2017-11-02 20:04 [PATCH][net-next] net: sched: cls_bpf: use bitwise & rather than logical && on gen_flags Colin King
@ 2017-11-02 22:20 ` Daniel Borkmann
2017-11-03 6:55 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Borkmann @ 2017-11-02 22:20 UTC (permalink / raw)
To: Colin King, Alexei Starovoitov, Jamal Hadi Salim, Cong Wang,
Jiri Pirko, David S . Miller, netdev
Cc: kernel-janitors, linux-kernel
On 11/02/2017 09:04 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently gen_flags is being operated on by a logical && operator rather
> than a bitwise & operator. This looks incorrect as these should be bit
> flag operations. Fix this.
>
> Detected by CoverityScan, CID#1460305 ("Logical vs. bitwise operator")
>
> Fixes: 3f7889c4c79b ("net: sched: cls_bpf: call block callbacks for offload)
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH][net-next] net: sched: cls_bpf: use bitwise & rather than logical && on gen_flags
2017-11-02 20:04 [PATCH][net-next] net: sched: cls_bpf: use bitwise & rather than logical && on gen_flags Colin King
2017-11-02 22:20 ` Daniel Borkmann
@ 2017-11-03 6:55 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-11-03 6:55 UTC (permalink / raw)
To: colin.king
Cc: ast, daniel, jhs, xiyou.wangcong, jiri, netdev, kernel-janitors,
linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Thu, 2 Nov 2017 20:04:12 +0000
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently gen_flags is being operated on by a logical && operator rather
> than a bitwise & operator. This looks incorrect as these should be bit
> flag operations. Fix this.
>
> Detected by CoverityScan, CID#1460305 ("Logical vs. bitwise operator")
>
> Fixes: 3f7889c4c79b ("net: sched: cls_bpf: call block callbacks for offload)
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-03 6:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-02 20:04 [PATCH][net-next] net: sched: cls_bpf: use bitwise & rather than logical && on gen_flags Colin King
2017-11-02 22:20 ` Daniel Borkmann
2017-11-03 6:55 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).