From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [patch net-next] net: sched: move block offload unbind after all chains are flushed Date: Fri, 3 Nov 2017 07:59:45 +0100 Message-ID: <20171103065945.GF2024@nanopsycho> References: <20171102140701.1485-1-jiri@resnulli.us> <20171103.154744.1648531780926119509.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, mlxsw@mellanox.com, alexander.h.duyck@intel.com, kubakici@wp.pl To: David Miller Return-path: Received: from mail-wr0-f181.google.com ([209.85.128.181]:43060 "EHLO mail-wr0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753226AbdKCG7r (ORCPT ); Fri, 3 Nov 2017 02:59:47 -0400 Received: by mail-wr0-f181.google.com with SMTP id w105so1632640wrc.0 for ; Thu, 02 Nov 2017 23:59:47 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20171103.154744.1648531780926119509.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: Fri, Nov 03, 2017 at 07:47:44AM CET, davem@davemloft.net wrote: >From: Jiri Pirko >Date: Thu, 2 Nov 2017 15:07:01 +0100 > >> From: Jiri Pirko >> >> Currently, the offload unbind is done before the chains are flushed. >> That causes driver to unregister block callback before it can get all >> the callback calls done during flush, leaving the offloaded tps inside >> the HW. So fix the order to prevent this situation and restore the >> original behaviour. >> >> Reported-by: Alexander Duyck >> Reported-by: Jakub Kicinski >> Signed-off-by: Jiri Pirko > >I'm pretty sure this was my fault during the merge, I had to pick >whether to do it before or after the offload unbind and I picked the >latter. I also had it wrong in the original commit 8c4083b30e56fc71b0e94c26374b32d95d5ea461 > >Applied, thank you. Thanks.