netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: felix.manlunas@cavium.com
Cc: netdev@vger.kernel.org, raghu.vatsavayi@cavium.com,
	derek.chickles@cavium.com, satananda.burla@cavium.com,
	vijaya.guvva@cavium.com
Subject: Re: [PATCH net-next] liquidio: Fix an issue with multiple switchdev enable disables
Date: Sat, 04 Nov 2017 09:18:31 +0900 (KST)	[thread overview]
Message-ID: <20171104.091831.822922406654465563.davem@davemloft.net> (raw)
In-Reply-To: <20171103191744.GA25280@felix-thinkpad.cavium.com>

From: Felix Manlunas <felix.manlunas@cavium.com>
Date: Fri, 3 Nov 2017 12:17:44 -0700

> From: Vijaya Mohan Guvva <vijaya.guvva@cavium.com>
> 
> Return success if the same dispatch function is being registered for
> a given opcode and subcode, there by allow multiple switchdev enable
> and disables.
> 
> Signed-off-by: Vijaya Mohan Guvva <vijaya.guvva@cavium.com>
> Signed-off-by: Satanand Burla <satananda.burla@cavium.com>
> Signed-off-by: Felix Manlunas <felix.manlunas@cavium.com>

Applied, thanks.

But I do have a question, are you properly reference counting these
dispatch function objects?  I can't see how you can properly handle
multiple enable/disable otherwise.

Thank you.

  reply	other threads:[~2017-11-04  0:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-03 19:17 [PATCH net-next] liquidio: Fix an issue with multiple switchdev enable disables Felix Manlunas
2017-11-04  0:18 ` David Miller [this message]
2017-11-06 23:36   ` Guvva, Vijaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171104.091831.822922406654465563.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=derek.chickles@cavium.com \
    --cc=felix.manlunas@cavium.com \
    --cc=netdev@vger.kernel.org \
    --cc=raghu.vatsavayi@cavium.com \
    --cc=satananda.burla@cavium.com \
    --cc=vijaya.guvva@cavium.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).