From: David Miller <davem@davemloft.net>
To: horms@verge.net.au
Cc: ja@ssi.bg, hustcat@gmail.com, willemb@google.com,
edumazet@google.com, johannes.berg@intel.com,
dcaratti@redhat.com, pabeni@redhat.com, f.fainelli@gmail.com,
fw@strlen.de, soheil@google.com, dwindsor@gmail.com,
elena.reshetova@intel.com, tom@quantonium.net, Jason@zx2c4.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
chouryzhou@gmail.com, wensong@linux-vs.org,
lvs-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter/ipvs: clear ipvs_property flag when SKB net namespace changed
Date: Sat, 04 Nov 2017 22:38:22 +0900 (KST) [thread overview]
Message-ID: <20171104.223822.848425746136000220.davem@davemloft.net> (raw)
In-Reply-To: <20171102144650.zqbfbv7lprrwpjl5@verge.net.au>
From: Simon Horman <horms@verge.net.au>
Date: Thu, 2 Nov 2017 15:46:50 +0100
> On Sat, Oct 28, 2017 at 01:33:09PM +0300, Julian Anastasov wrote:
>>
>> Hello,
>>
>> On Thu, 26 Oct 2017, Ye Yin wrote:
>>
>> > When run ipvs in two different network namespace at the same host, and one
>> > ipvs transport network traffic to the other network namespace ipvs.
>> > 'ipvs_property' flag will make the second ipvs take no effect. So we should
>> > clear 'ipvs_property' when SKB network namespace changed.
>> >
>> > Signed-off-by: Ye Yin <hustcat@gmail.com>
>> > Signed-off-by: Wei Zhou <chouryzhou@gmail.com>
>>
>> Patch looks good to me. ipvs_property was added long ago
>> but skb_scrub_packet() is more recent (3.11), so:
>>
>> Fixes: 621e84d6f373 ("dev: introduce skb_scrub_packet()")
>> Signed-off-by: Julian Anastasov <ja@ssi.bg>
>>
>> I guess, DaveM can apply it directly as a bugfix
>> to the net tree.
>
> Sounds like a good plan to me, Dave?
>
> Signed-off-by: Simon Horman <horms@verge.net.au>
Sure, applied and queued up for -stable, thanks!
prev parent reply other threads:[~2017-11-04 13:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 8:57 [PATCH] netfilter/ipvs: clear ipvs_property flag when SKB net namespace changed Ye Yin
2017-10-28 10:33 ` Julian Anastasov
2017-11-02 14:46 ` Simon Horman
2017-11-04 13:38 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171104.223822.848425746136000220.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Jason@zx2c4.com \
--cc=chouryzhou@gmail.com \
--cc=dcaratti@redhat.com \
--cc=dwindsor@gmail.com \
--cc=edumazet@google.com \
--cc=elena.reshetova@intel.com \
--cc=f.fainelli@gmail.com \
--cc=fw@strlen.de \
--cc=horms@verge.net.au \
--cc=hustcat@gmail.com \
--cc=ja@ssi.bg \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=soheil@google.com \
--cc=tom@quantonium.net \
--cc=wensong@linux-vs.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).