From: Masami Hiramatsu <mhiramat@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Build bot for Mark Brown <broonie@kernel.org>,
Kernel Build Reports Mailman List
<kernel-build-reports@lists.linaro.org>,
linaro-kernel@lists.linaro.org,
Linux-Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Stephen Hemminger <stephen@networkplumber.org>,
Networking <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Daniel Borkmann <dborkman@redhat.com>,
Ian McDonald <ian.mcdonald@jandi.co.nz>,
Wei Yongjun <yjwei@cn.fujitsu.com>
Subject: Re: next-20171103 build: 3 failures 22 warnings (next-20171103)
Date: Sat, 4 Nov 2017 06:12:40 +0900 [thread overview]
Message-ID: <20171104061240.0c56c5e9f3ede3341e8fd4a9@kernel.org> (raw)
In-Reply-To: <CAK8P3a1j5p7wYpwY3neF8Z4EwcFsS6TciEy3UAcGaSfujrQN_Q@mail.gmail.com>
On Fri, 3 Nov 2017 21:16:21 +0100
Arnd Bergmann <arnd@arndb.de> wrote:
> On Fri, Nov 3, 2017 at 8:27 PM, Masami Hiramatsu <mhiramat@kernel.org> wrote:
> > On Fri, 3 Nov 2017 15:44:53 +0100 Arnd Bergmann <arnd@arndb.de> wrote:
> >> On Fri, Nov 3, 2017 at 1:44 PM, Build bot for Mark Brown <broonie@kernel.org> wrote:
> >>
> >> > Warnings Summary: 22
> >> > 2 ../net/sctp/probe.c:240:2: warning: 'unregister_jprobe' is deprecated [-Wdeprecated-declarations]
> >> > 2 ../net/sctp/probe.c:194:3: warning: 'register_jprobe' is deprecated [-Wdeprecated-declarations]
> >> > 2 ../net/sctp/probe.c:189:2: warning: 'register_jprobe' is deprecated [-Wdeprecated-declarations]
> >> > 2 ../net/ipv4/tcp_probe.c:298:2: warning: 'unregister_jprobe' is deprecated [-Wdeprecated-declarations]
> >> > 2 ../net/ipv4/tcp_probe.c:280:2: warning: 'register_jprobe' is deprecated [-Wdeprecated-declarations]
> >> > 2 ../net/dccp/probe.c:190:2: warning: 'unregister_jprobe' is deprecated [-Wdeprecated-declarations]
> >> > 2 ../net/dccp/probe.c:170:4: warning: 'register_jprobe' is deprecated [-Wdeprecated-declarations]
> >> > 2 ../net/dccp/probe.c:166:2: warning: 'register_jprobe' is deprecated [-Wdeprecated-declarations]
> >> > 1 ../arch/arm/probes/kprobes/test-core.c:398:2: warning: 'unregister_jprobe' is deprecated [-Wdeprecated-declarations]
> >> > 1 ../arch/arm/probes/kprobes/test-core.c:390:2: warning: 'register_jprobe' is deprecated [-Wdeprecated-declarations]
> >>
> >> I need a little help from Masami Hiramatsu to understand what the plan is here:
> >> Do we just need to remove those files now that jprobes are gone, or do
> >> we actually want to restore the functionality using some other replacement code?
> >>
> >> I'm asking because the __deprecated warning seems unhelpful if there
> >> isn't an easy way to address the warning.
> >
> > It seems that the arm/probes case is just for testing, I'll just remove it
> > because it's functionality is gone.
>
> Makes sense, thanks!
>
> > Others should be decided by network maintainers. Maybe those are not used anymore,
> > or should be rewritten by kprobes or ftrace.
>
> Added a few people to cc that worked on {tcp,dccp,sctp}_probe in the past
> for clarification. Do you already have plans to deal with this?
As far as I can see, those features can not be fixed simply using kprobes because
they are using function arguments. Fortunately we already have trace-events nowadays.
So my suggestion is adding trace-events in the target function with required
arguments, rewrite user-space tools to use ftrace, and remove the modules.
Thank you,
--
Masami Hiramatsu <mhiramat@kernel.org>
prev parent reply other threads:[~2017-11-03 21:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1eAbKY-0001Sc-Ue@optimist>
[not found] ` <CAK8P3a2JFOgp5nPmEnM9NATutQ_+aSxdHGh6YHcnveMJ+eASJg@mail.gmail.com>
[not found] ` <20171104042729.2196dbe1ad905c71f18cbb1e@kernel.org>
2017-11-03 20:16 ` next-20171103 build: 3 failures 22 warnings (next-20171103) Arnd Bergmann
2017-11-03 21:12 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171104061240.0c56c5e9f3ede3341e8fd4a9@kernel.org \
--to=mhiramat@kernel.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=ian.mcdonald@jandi.co.nz \
--cc=kernel-build-reports@lists.linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=yjwei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).