From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] tools: bpftool: move p_err() and p_info() from main.h to common.c Date: Sun, 05 Nov 2017 22:29:05 +0900 (KST) Message-ID: <20171105.222905.2113705675362671569.davem@davemloft.net> References: <20171103205907.23281-1-jakub.kicinski@netronome.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, oss-drivers@netronome.com, quentin.monnet@netronome.com To: jakub.kicinski@netronome.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:46224 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751952AbdKEN3K (ORCPT ); Sun, 5 Nov 2017 08:29:10 -0500 In-Reply-To: <20171103205907.23281-1-jakub.kicinski@netronome.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Jakub Kicinski Date: Fri, 3 Nov 2017 13:59:07 -0700 > From: Quentin Monnet > > The two functions were declared as static inline in a header file. There > is no particular reason why they should be inlined, they just happened to > remain in the same header file when they were turned from macros to > functions in a precious commit. > > Make them non-inlined functions and move them to common.c file instead. > > Suggested-by: Joe Perches > Signed-off-by: Quentin Monnet > Signed-off-by: Jakub Kicinski Applied.