netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pieter Jansen van Vuuren <pieter.jansenvanvuuren@netronome.com>
To: Manish Kurup <kurup.manish@gmail.com>
Cc: David Miller <davem@davemloft.net>,
	Jamal Hadi Salim <jhs@mojatatu.com>,
	Cong Wang <xiyou.wangcong@gmail.com>,
	Jiri Pirko <jiri@resnulli.us>,
	jakub.kicinski@netronome.com, simon.horman@netronome.com,
	john.hurley@netronome.com, Alexander Aring <aring@mojatatu.com>,
	Roman Mashak <mrv@mojatatu.com>,
	Manish Kurup <manish.kurup@verizon.com>,
	netdev@vger.kernel.org, oss-drivers@netronome.com
Subject: Re: [PATCH net-next v6 0/3] Incorporated all required changes
Date: Mon, 6 Nov 2017 18:25:12 +0000	[thread overview]
Message-ID: <20171106182512.68786484@pieter-Netronome> (raw)
In-Reply-To: <CAJrKpLaNX4gX0yTkKkRvmU=Ti3xYGkoEu4cAcDhwnZF2tZU1SA@mail.gmail.com>

On Mon, 6 Nov 2017 11:52:37 -0500
Manish Kurup <kurup.manish@gmail.com> wrote:

> Hi Dave,
> 
> On Sun, Nov 5, 2017 at 8:08 AM, David Miller <davem@davemloft.net> wrote:
> 
> > From: Manish Kurup <kurup.manish@gmail.com>
> > Date: Fri,  3 Nov 2017 11:49:19 -0400
> >  
> > > Modified the netronome drivers (flower action) to use the VLAN helper
> > > functions instead of dereferencing the structure directly. This is
> > > required for the VLAN action patch.
> > >
> > > Could you please review?  
> >
> > Please use a more appropriate patch series header posting than this.
> >
> > This subject shall describe what the patch series is about, in much
> > the same style as a normal commit, using appropriate subsystem
> > prefixes and so on.
> >
> > The commit message body must describe what the patch series is doing,
> > how it is doing it, and why it is doing it that way.
> >  
> 
> Mistakenly unicasted my reply (below) to Dave.
> 
> Currently, the body of the commit message describes what it is doing in
> each commit patch. Would you like me to add some detail to the
> description of each commit?
Hi Manish, Your patch series header is "Incorporated all required
changes", could you update this to something more descriptive?

  parent reply	other threads:[~2017-11-06 18:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-03 15:49 [PATCH net-next v6 0/3] Incorporated all required changes Manish Kurup
2017-11-05 13:08 ` David Miller
     [not found]   ` <CAJrKpLaNX4gX0yTkKkRvmU=Ti3xYGkoEu4cAcDhwnZF2tZU1SA@mail.gmail.com>
2017-11-06 18:25     ` Pieter Jansen van Vuuren [this message]
2017-11-06 23:45     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171106182512.68786484@pieter-Netronome \
    --to=pieter.jansenvanvuuren@netronome.com \
    --cc=aring@mojatatu.com \
    --cc=davem@davemloft.net \
    --cc=jakub.kicinski@netronome.com \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=john.hurley@netronome.com \
    --cc=kurup.manish@gmail.com \
    --cc=manish.kurup@verizon.com \
    --cc=mrv@mojatatu.com \
    --cc=netdev@vger.kernel.org \
    --cc=oss-drivers@netronome.com \
    --cc=simon.horman@netronome.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).