From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pieter Jansen van Vuuren Subject: Re: [PATCH net-next v6 0/3] Incorporated all required changes Date: Mon, 6 Nov 2017 18:25:12 +0000 Message-ID: <20171106182512.68786484@pieter-Netronome> References: <1509724159-5559-1-git-send-email-manish.kurup@verizon.com> <20171105.220843.222678154572186350.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: David Miller , Jamal Hadi Salim , Cong Wang , Jiri Pirko , jakub.kicinski@netronome.com, simon.horman@netronome.com, john.hurley@netronome.com, Alexander Aring , Roman Mashak , Manish Kurup , netdev@vger.kernel.org, oss-drivers@netronome.com To: Manish Kurup Return-path: Received: from mail-wr0-f195.google.com ([209.85.128.195]:52640 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932729AbdKFSZS (ORCPT ); Mon, 6 Nov 2017 13:25:18 -0500 Received: by mail-wr0-f195.google.com with SMTP id j23so5333953wra.9 for ; Mon, 06 Nov 2017 10:25:17 -0800 (PST) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 6 Nov 2017 11:52:37 -0500 Manish Kurup wrote: > Hi Dave, > > On Sun, Nov 5, 2017 at 8:08 AM, David Miller wrote: > > > From: Manish Kurup > > Date: Fri, 3 Nov 2017 11:49:19 -0400 > > > > > Modified the netronome drivers (flower action) to use the VLAN helper > > > functions instead of dereferencing the structure directly. This is > > > required for the VLAN action patch. > > > > > > Could you please review? > > > > Please use a more appropriate patch series header posting than this. > > > > This subject shall describe what the patch series is about, in much > > the same style as a normal commit, using appropriate subsystem > > prefixes and so on. > > > > The commit message body must describe what the patch series is doing, > > how it is doing it, and why it is doing it that way. > > > > Mistakenly unicasted my reply (below) to Dave. > > Currently, the body of the commit message describes what it is doing in > each commit patch. Would you like me to add some detail to the > description of each commit? Hi Manish, Your patch series header is "Incorporated all required changes", could you update this to something more descriptive?