From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pieter Jansen van Vuuren Subject: Re: [PATCH net-next v6 2/3] nfp flower action: Modified to use VLAN helper functions Date: Mon, 6 Nov 2017 18:33:32 +0000 Message-ID: <20171106183332.22348570@pieter-Netronome> References: <1509724225-5670-1-git-send-email-manish.kurup@verizon.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net, jakub.kicinski@netronome.com, simon.horman@netronome.com, john.hurley@netronome.com, oss-drivers@netronome.com, netdev@vger.kernel.org, aring@mojatatu.com, mrv@mojatatu.com, Manish Kurup To: Manish Kurup Return-path: Received: from mail-wr0-f196.google.com ([209.85.128.196]:51765 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752240AbdKFSdg (ORCPT ); Mon, 6 Nov 2017 13:33:36 -0500 Received: by mail-wr0-f196.google.com with SMTP id j15so9529697wre.8 for ; Mon, 06 Nov 2017 10:33:36 -0800 (PST) In-Reply-To: <1509724225-5670-1-git-send-email-manish.kurup@verizon.com> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 3 Nov 2017 11:50:25 -0400 Manish Kurup wrote: > Modified netronome nfp flower action to use VLAN helper functions instead > of accessing the structure directly. > > Signed-off-by: Manish Kurup > --- > drivers/net/ethernet/netronome/nfp/flower/action.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/netronome/nfp/flower/action.c > b/drivers/net/ethernet/netronome/nfp/flower/action.c index de64ced..c1c595f > 100644 --- a/drivers/net/ethernet/netronome/nfp/flower/action.c > +++ b/drivers/net/ethernet/netronome/nfp/flower/action.c > @@ -58,7 +58,6 @@ nfp_fl_push_vlan(struct nfp_fl_push_vlan *push_vlan, > const struct tc_action *action) > { > size_t act_size = sizeof(struct nfp_fl_push_vlan); > - struct tcf_vlan *vlan = to_vlan(action); > u16 tmp_push_vlan_tci; > > push_vlan->head.jump_id = NFP_FL_ACTION_OPCODE_PUSH_VLAN; > @@ -67,8 +66,8 @@ nfp_fl_push_vlan(struct nfp_fl_push_vlan *push_vlan, > push_vlan->vlan_tpid = tcf_vlan_push_proto(action); > > tmp_push_vlan_tci = > - FIELD_PREP(NFP_FL_PUSH_VLAN_PRIO, vlan->tcfv_push_prio) | > - FIELD_PREP(NFP_FL_PUSH_VLAN_VID, vlan->tcfv_push_vid) | > + FIELD_PREP(NFP_FL_PUSH_VLAN_PRIO, > tcf_vlan_push_prio(action)) | > + FIELD_PREP(NFP_FL_PUSH_VLAN_VID, tcf_vlan_push_vid(action)) > | NFP_FL_PUSH_VLAN_CFI; > push_vlan->vlan_tci = cpu_to_be16(tmp_push_vlan_tci); > } Thank you for this; you may consider this patch: Reviewed-by: Pieter Jansen van Vuuren