From: David Miller <davem@davemloft.net>
To: alexander.duyck@gmail.com
Cc: pieter.jansenvanvuuren@netronome.com, kurup.manish@gmail.com,
jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
jakub.kicinski@netronome.com, simon.horman@netronome.com,
john.hurley@netronome.com, oss-drivers@netronome.com,
netdev@vger.kernel.org, aring@mojatatu.com, mrv@mojatatu.com,
manish.kurup@verizon.com
Subject: Re: [PATCH net-next v6 3/3] act_vlan: VLAN action rewrite to use RCU lock/unlock and update
Date: Wed, 08 Nov 2017 09:07:27 +0900 (KST) [thread overview]
Message-ID: <20171108.090727.1485121667800460011.davem@davemloft.net> (raw)
In-Reply-To: <CAKgT0Udx73GNT39aHrmsaXbqGhiMxejygAQxUg3FM5Rm=ZpfKg@mail.gmail.com>
From: Alexander Duyck <alexander.duyck@gmail.com>
Date: Tue, 7 Nov 2017 08:54:20 -0800
> Are we really going to be so strict about the reverse xmas-tree that
> we won't allow for assignment w/ variable declaration because the
> dependency order won't fit into that format?
Yes.
> Last I knew this kind of setup was an exception to the reverse
> xmas-tree layout requirement because in this case 'p' relies on 'v' so
> we can't reorder these without having to kick the assignment of 'p'
> off onto a line by itself.
Please just declare the variable naked without the assignment and do
the assignment down in the code.
next prev parent reply other threads:[~2017-11-08 0:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-03 15:50 [PATCH net-next v6 3/3] act_vlan: VLAN action rewrite to use RCU lock/unlock and update Manish Kurup
2017-11-06 18:37 ` Pieter Jansen van Vuuren
2017-11-07 16:54 ` Alexander Duyck
2017-11-07 17:08 ` Pieter Jansen van Vuuren
2017-11-08 0:07 ` David Miller [this message]
[not found] ` <CAJrKpLZenHyuZimWE0CfHePFktB0B-7sa-BO1ff29sXqtiN7EA@mail.gmail.com>
2017-11-08 11:43 ` Fwd: " Manish Kurup
2017-11-08 12:13 ` Manish Kurup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171108.090727.1485121667800460011.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.duyck@gmail.com \
--cc=aring@mojatatu.com \
--cc=jakub.kicinski@netronome.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=john.hurley@netronome.com \
--cc=kurup.manish@gmail.com \
--cc=manish.kurup@verizon.com \
--cc=mrv@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=pieter.jansenvanvuuren@netronome.com \
--cc=simon.horman@netronome.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).