From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next v6 3/3] act_vlan: VLAN action rewrite to use RCU lock/unlock and update Date: Wed, 08 Nov 2017 09:07:27 +0900 (KST) Message-ID: <20171108.090727.1485121667800460011.davem@davemloft.net> References: <1509724247-5721-1-git-send-email-manish.kurup@verizon.com> <20171106183731.3e1e88fc@pieter-Netronome> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: pieter.jansenvanvuuren@netronome.com, kurup.manish@gmail.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, jakub.kicinski@netronome.com, simon.horman@netronome.com, john.hurley@netronome.com, oss-drivers@netronome.com, netdev@vger.kernel.org, aring@mojatatu.com, mrv@mojatatu.com, manish.kurup@verizon.com To: alexander.duyck@gmail.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:58856 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758473AbdKHAHf (ORCPT ); Tue, 7 Nov 2017 19:07:35 -0500 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Alexander Duyck Date: Tue, 7 Nov 2017 08:54:20 -0800 > Are we really going to be so strict about the reverse xmas-tree that > we won't allow for assignment w/ variable declaration because the > dependency order won't fit into that format? Yes. > Last I knew this kind of setup was an exception to the reverse > xmas-tree layout requirement because in this case 'p' relies on 'v' so > we can't reorder these without having to kick the assignment of 'p' > off onto a line by itself. Please just declare the variable naked without the assignment and do the assignment down in the code.