From: David Miller <davem@davemloft.net>
To: mail@maciej.szmigiero.name
Cc: andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] net: phy: leds: Refactor "no link" handler into a separate function
Date: Wed, 08 Nov 2017 10:25:13 +0900 (KST) [thread overview]
Message-ID: <20171108.102513.1587986704874969740.davem@davemloft.net> (raw)
In-Reply-To: <2c037f1c-ad1a-ebd9-2307-eb902cbb2c99@maciej.szmigiero.name>
From: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Date: Thu, 2 Nov 2017 00:48:45 +0100
> Currently, phy_led_trigger_change_speed() is handling a "no link" condition
> like it was some kind of an error (using "goto" to a code at the function
> end).
>
> However, having no link at PHY is an ordinary operational state, so let's
> handle it in an appropriately named separate function so it is more obvious
> what the code is doing.
>
> Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
Applied.
prev parent reply other threads:[~2017-11-08 1:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-01 23:48 [PATCH v3 1/2] net: phy: leds: Refactor "no link" handler into a separate function Maciej S. Szmigiero
2017-11-08 1:25 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171108.102513.1587986704874969740.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@maciej.szmigiero.name \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).