From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH v3 1/2] net: phy: leds: Refactor "no link" handler into
 a separate function
Date: Wed, 08 Nov 2017 10:25:13 +0900 (KST)
Message-ID: <20171108.102513.1587986704874969740.davem@davemloft.net>
References: <2c037f1c-ad1a-ebd9-2307-eb902cbb2c99@maciej.szmigiero.name>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
To: mail@maciej.szmigiero.name
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <2c037f1c-ad1a-ebd9-2307-eb902cbb2c99@maciej.szmigiero.name>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

From: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Date: Thu, 2 Nov 2017 00:48:45 +0100

> Currently, phy_led_trigger_change_speed() is handling a "no link" condition
> like it was some kind of an error (using "goto" to a code at the function
> end).
> 
> However, having no link at PHY is an ordinary operational state, so let's
> handle it in an appropriately named separate function so it is more obvious
> what the code is doing.
> 
> Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>

Applied.