From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH v3 2/2] net: phy: leds: Add support for "link" trigger Date: Wed, 08 Nov 2017 10:25:21 +0900 (KST) Message-ID: <20171108.102521.1965425774011333434.davem@davemloft.net> References: <2302346f-5bcb-0326-362d-888de24839d3@maciej.szmigiero.name> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: mail@maciej.szmigiero.name Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:59660 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751168AbdKHBZY (ORCPT ); Tue, 7 Nov 2017 20:25:24 -0500 In-Reply-To: <2302346f-5bcb-0326-362d-888de24839d3@maciej.szmigiero.name> Sender: netdev-owner@vger.kernel.org List-ID: From: "Maciej S. Szmigiero" Date: Thu, 2 Nov 2017 00:49:18 +0100 > Currently, we create a LED trigger for any link speed known to a PHY. > These triggers only fire when their exact link speed had been negotiated > (they aren't cumulative, that is, they don't fire for "their or any higher" > link speed). > > What we are missing, however, is a trigger which will fire on any link > speed known to the PHY. Such trigger can then be used for implementing a > poor man's substitute of the "link" LED on boards that lack it. > Let's add it. > > Signed-off-by: Maciej S. Szmigiero Also applied, thank you.