From: David Miller <davem@davemloft.net>
To: marc.zyngier@arm.com
Cc: thomas.petazzoni@free-electrons.com,
antoine.tenart@free-electrons.com, netdev@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] net: mvpp2: Prevent userspace from changing TX affinities
Date: Wed, 08 Nov 2017 10:31:56 +0900 (KST) [thread overview]
Message-ID: <20171108.103156.136116035076396821.davem@davemloft.net> (raw)
In-Reply-To: <20171104123347.20540-1-marc.zyngier@arm.com>
From: Marc Zyngier <marc.zyngier@arm.com>
Date: Sat, 4 Nov 2017 12:33:47 +0000
> The mvpp2 driver can't cope at all with the TX affinities being
> changed from userspace, and spit an endless stream of
>
> [ 91.779920] mvpp2 f4000000.ethernet eth2: wrong cpu on the end of Tx processing
> [ 91.779930] mvpp2 f4000000.ethernet eth2: wrong cpu on the end of Tx processing
> [ 91.780402] mvpp2 f4000000.ethernet eth2: wrong cpu on the end of Tx processing
> [ 91.780406] mvpp2 f4000000.ethernet eth2: wrong cpu on the end of Tx processing
> [ 91.780415] mvpp2 f4000000.ethernet eth2: wrong cpu on the end of Tx processing
> [ 91.780418] mvpp2 f4000000.ethernet eth2: wrong cpu on the end of Tx processing
>
> rendering the box completely useless (I've measured around 600k
> interrupts/s on a 8040 box) once irqbalance kicks in and start
> doing its job.
>
> Obviously, the driver was never designed with this in mind. So let's
> work around the problem by preventing userspace from interacting
> with these interrupts altogether.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2017-11-08 1:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-04 12:33 [PATCH] net: mvpp2: Prevent userspace from changing TX affinities Marc Zyngier
2017-11-08 1:31 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171108.103156.136116035076396821.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=antoine.tenart@free-electrons.com \
--cc=marc.zyngier@arm.com \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).