netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: u9012063@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/3] ip6_gre: Refactor ip6gre xmit codes
Date: Wed, 08 Nov 2017 11:10:19 +0900 (KST)	[thread overview]
Message-ID: <20171108.111019.1748234296465560337.davem@davemloft.net> (raw)
In-Reply-To: <1509907145-42750-3-git-send-email-u9012063@gmail.com>

From: William Tu <u9012063@gmail.com>
Date: Sun,  5 Nov 2017 10:39:04 -0800

> diff --git a/net/ipv6/ip6_gre.c b/net/ipv6/ip6_gre.c
> index 3e10c51e7e0c..8c7612f32926 100644
> --- a/net/ipv6/ip6_gre.c
> +++ b/net/ipv6/ip6_gre.c
> @@ -497,6 +497,79 @@ static int gre_handle_offloads(struct sk_buff *skb, bool csum)
>  					csum ? SKB_GSO_GRE_CSUM : SKB_GSO_GRE);
>  }
>  
> +static inline void prepare_ip6gre_xmit_ipv4(struct sk_buff *skb,
> +					    struct net_device *dev,
> +					    struct flowi6 *fl6, __u8 *dsfield,
> +					    int *encap_limit)

Please do not use 'inline' in foo.c files, let the compiler decide.

Thank you.

  reply	other threads:[~2017-11-08  2:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-05 18:39 [PATCH net-next 0/3] ip6_gre: add erspan native tunnel for ipv6 William Tu
2017-11-05 18:39 ` [PATCH net-next 1/3] ip_gre: Refector the erpsan tunnel code William Tu
2017-11-05 18:39 ` [PATCH net-next 2/3] ip6_gre: Refactor ip6gre xmit codes William Tu
2017-11-08  2:10   ` David Miller [this message]
2017-11-08 13:06     ` William Tu
2017-11-05 18:39 ` [PATCH net-next 3/3] ip6_gre: Add ERSPAN native tunnel support William Tu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171108.111019.1748234296465560337.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=u9012063@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).