From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [patch net-next 0/9] qdisc RED offload Date: Wed, 08 Nov 2017 12:28:55 +0900 (KST) Message-ID: <20171108.122855.673986719935863302.davem@davemloft.net> References: <20171106062349.4873-1-jiri@resnulli.us> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, nogahf@mellanox.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com, mlxsw@mellanox.com, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, michael.chan@broadcom.com, ganeshgr@chelsio.com, saeedm@mellanox.com, matanb@mellanox.com, leonro@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, simon.horman@netronome.com, pieter.jansenvanvuuren@netronome.com, john.hurley@netronome.com, alexander.h.duyck@intel.com, ogerlitz@mellanox.com, john.fastabend@gmail.com To: jiri@resnulli.us Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:33124 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751140AbdKHD3F (ORCPT ); Tue, 7 Nov 2017 22:29:05 -0500 In-Reply-To: <20171106062349.4873-1-jiri@resnulli.us> Sender: netdev-owner@vger.kernel.org List-ID: From: Jiri Pirko Date: Mon, 6 Nov 2017 07:23:40 +0100 > From: Jiri Pirko > > Nogah says: > > Add an offload support for RED qdisc for mlxsw driver. > The first patch adds the ability to offload RED qdisc by using > ndo_setup_tc. It gives RED three commands, to offload, change or delete > the qdisc, to get the qdisc generic stats and to get it's RED xstats. > There is no enforcement on a driver to offload or not offload the qdisc and > it is up to the driver to decide. > RED qdisc is first being created and only later graft to a parent (unless > it is a root qdisc). For that reason the return value of the offload > replace command that is called in the init process doesn't reflect actual > offload state. The offload state is determined in the dump function so it > can be reflected to the user. This function is also responsible for stats > update. > > The patchses 2-3 change the name of TC_SETUP_MQPRIO & TC_SETUP_CBS to match > with the new convention of QDISC prefix. > The rest of the patchset is driver support for the qdisc. Currently only > as root qdisc that is being set on the default traffic class. It supports > only the following parameters of RED: min, max, probability and ECN mode. > Limit and burst size related params are being ignored at this moment. Series applied, thanks!