From: David Miller <davem@davemloft.net>
To: m.grzeschik@pengutronix.de
Cc: nicolas.ferre@microchip.com, netdev@vger.kernel.org,
kernel@pengutronix.de, andrew@lunn.ch
Subject: Re: [PATCH 1/2] net: macb: add of_phy_deregister_fixed_link to error paths
Date: Wed, 08 Nov 2017 13:22:57 +0900 (KST) [thread overview]
Message-ID: <20171108.132257.965316421222736859.davem@davemloft.net> (raw)
In-Reply-To: <20171106111005.2999-1-m.grzeschik@pengutronix.de>
From: Michael Grzeschik <m.grzeschik@pengutronix.de>
Date: Mon, 6 Nov 2017 12:10:04 +0100
> We add the call of_phy_deregister_fixed_link to all associated
> error paths for memory clean up.
>
> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> ---
> drivers/net/ethernet/cadence/macb_main.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
> index 6df2cad61647a..2c2acd011329a 100644
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -611,6 +611,8 @@ static int macb_mii_init(struct macb *bp)
> err_out_unregister_bus:
> mdiobus_unregister(bp->mii_bus);
> err_out_free_mdiobus:
> + if ((np) && (of_phy_is_fixed_link(np)))
Please don't use so many parenthesis in your conditionals:
if (np && of_phy_is_fixed_link(np))
is more than sufficient.
Please fix this in your entire set of patches.
Thank you.
next prev parent reply other threads:[~2017-11-08 4:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-23 14:54 [PATCH v2] net: macb: add fixed-link node support Michael Grzeschik
2017-06-25 19:22 ` David Miller
2017-11-06 9:26 ` Nicolas Ferre
2017-11-06 11:10 ` [PATCH 1/2] net: macb: add of_phy_deregister_fixed_link to error paths Michael Grzeschik
2017-11-06 11:10 ` [PATCH 2/2] net: macb: add of_node_put " Michael Grzeschik
2017-11-07 9:27 ` Nicolas Ferre
2017-11-07 9:59 ` [PATCH v2] " Michael Grzeschik
2017-11-07 11:12 ` Nicolas Ferre
2017-11-08 6:29 ` David Miller
2017-11-07 10:00 ` [PATCH 2/2] " Michael Grzeschik
2017-11-06 14:37 ` [PATCH 1/2] net: macb: add of_phy_deregister_fixed_link " Nicolas Ferre
2017-11-08 4:22 ` David Miller [this message]
2017-11-08 8:41 ` Michael Grzeschik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171108.132257.965316421222736859.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=kernel@pengutronix.de \
--cc=m.grzeschik@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).