From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 1/2] net: macb: add of_phy_deregister_fixed_link to error paths Date: Wed, 08 Nov 2017 13:22:57 +0900 (KST) Message-ID: <20171108.132257.965316421222736859.davem@davemloft.net> References: <20171106111005.2999-1-m.grzeschik@pengutronix.de> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: nicolas.ferre@microchip.com, netdev@vger.kernel.org, kernel@pengutronix.de, andrew@lunn.ch To: m.grzeschik@pengutronix.de Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:33790 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751417AbdKHEXC (ORCPT ); Tue, 7 Nov 2017 23:23:02 -0500 In-Reply-To: <20171106111005.2999-1-m.grzeschik@pengutronix.de> Sender: netdev-owner@vger.kernel.org List-ID: From: Michael Grzeschik Date: Mon, 6 Nov 2017 12:10:04 +0100 > We add the call of_phy_deregister_fixed_link to all associated > error paths for memory clean up. > > Signed-off-by: Michael Grzeschik > --- > drivers/net/ethernet/cadence/macb_main.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c > index 6df2cad61647a..2c2acd011329a 100644 > --- a/drivers/net/ethernet/cadence/macb_main.c > +++ b/drivers/net/ethernet/cadence/macb_main.c > @@ -611,6 +611,8 @@ static int macb_mii_init(struct macb *bp) > err_out_unregister_bus: > mdiobus_unregister(bp->mii_bus); > err_out_free_mdiobus: > + if ((np) && (of_phy_is_fixed_link(np))) Please don't use so many parenthesis in your conditionals: if (np && of_phy_is_fixed_link(np)) is more than sufficient. Please fix this in your entire set of patches. Thank you.