From: David Miller <davem@davemloft.net>
To: jon.maloy@ericsson.com
Cc: netdev@vger.kernel.org,
mohan.krishna.ghanta.krishnamurthy@ericsson.com,
tung.q.nguyen@dektech.com.au, hoang.h.le@dektech.com.au,
canh.d.luu@dektech.com.au, ying.xue@windriver.com,
tipc-discussion@lists.sourceforge.net
Subject: Re: [net-next 1/1] tipc: improve link resiliency when rps is activated
Date: Wed, 08 Nov 2017 13:40:53 +0900 (KST) [thread overview]
Message-ID: <20171108.134053.127884187686446469.davem@davemloft.net> (raw)
In-Reply-To: <1509968651-16168-1-git-send-email-jon.maloy@ericsson.com>
From: Jon Maloy <jon.maloy@ericsson.com>
Date: Mon, 6 Nov 2017 12:44:11 +0100
> + return core & (num_online_cpus() - 1);
Well, this isn't exactly correct. The number of online cpus is not
necessarily a power of two.
And furthermore it shouldn't even be necessary. Just pass the whole
key around, it will have the modulus applied to it when needed
elsewhere in the call chains.
next prev parent reply other threads:[~2017-11-08 4:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 11:44 [net-next 1/1] tipc: improve link resiliency when rps is activated Jon Maloy
2017-11-08 4:40 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-11-06 14:27 Jon Maloy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171108.134053.127884187686446469.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=canh.d.luu@dektech.com.au \
--cc=hoang.h.le@dektech.com.au \
--cc=jon.maloy@ericsson.com \
--cc=mohan.krishna.ghanta.krishnamurthy@ericsson.com \
--cc=netdev@vger.kernel.org \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=tung.q.nguyen@dektech.com.au \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).