netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: andrew@lunn.ch
Cc: netdev@vger.kernel.org, vivien.didelot@savoirfairelinux.com,
	f.fainelli@gmail.com
Subject: Re: [PATCH v2 net-next 0/6] mv88e6xxx broadcast flooding in hardware
Date: Wed, 08 Nov 2017 14:01:38 +0900 (KST)	[thread overview]
Message-ID: <20171108.140138.85056790380753198.davem@davemloft.net> (raw)
In-Reply-To: <20171108.135809.1971169409102508174.davem@davemloft.net>

From: David Miller <davem@davemloft.net>
Date: Wed, 08 Nov 2017 13:58:09 +0900 (KST)

> From: Andrew Lunn <andrew@lunn.ch>
> Date: Tue,  7 Nov 2017 00:02:25 +0100
> 
>> This patchset makes the mv88e6xxx driver perform flooding in hardware,
>> rather than let the software bridge perform the flooding. This is a
>> prerequisite for IGMP snooping on the bridge interface.
>> 
>> In order to make hardware broadcasting work, a few other issues need
>> fixing or improving. SWITCHDEV_ATTR_ID_PORT_PARENT_ID is broken, which
>> is apparent when testing on the ZII devel board with multiple
>> switches.
>> 
>> Some of these patches are taken from a previous RFC patchset of IGMP
>> support.
> 
> Series applied, thanks Andrew.

Hmmm, I think there might be some in-flight conflict with Vivien's recent
DSA refactoring.

net/dsa/slave.c: In function ‘dsa_slave_port_attr_get’:
net/dsa/slave.c:349:35: error: ‘struct dsa_switch_tree’ has no member named ‘tree’
   attr->u.ppid.id_len = sizeof(dst->tree);
                                   ^~
net/dsa/slave.c:350:32: error: ‘struct dsa_switch_tree’ has no member named ‘tree’
   memcpy(&attr->u.ppid.id, &dst->tree, attr->u.ppid.id_len);
                                ^~

Anyways, I had to revert, please fix this up and resubmit.

Thank you!

  reply	other threads:[~2017-11-08  5:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-06 23:02 [PATCH v2 net-next 0/6] mv88e6xxx broadcast flooding in hardware Andrew Lunn
2017-11-06 23:02 ` [PATCH v2 net-next 1/6] net: dsa: Fix SWITCHDEV_ATTR_ID_PORT_PARENT_ID Andrew Lunn
2017-11-06 23:17   ` Florian Fainelli
2017-11-06 23:02 ` [PATCH v2 net-next 2/6] net: dsa: {e}dsa: set offload_fwd_mark on received packets Andrew Lunn
2017-11-06 23:02 ` [PATCH v2 net-next 3/6] net: dsa: mv88e6xxx: Fixed port netdev check for VLANs Andrew Lunn
2017-11-06 23:02 ` [PATCH v2 net-next 4/6] net: dsa: mv88e6xxx: Print offending port when vlan check fails Andrew Lunn
2017-11-06 23:02 ` [PATCH v2 net-next 5/6] net: dsa: mv88e6xxx: Move mv88e6xxx_port_db_load_purge() Andrew Lunn
2017-11-06 23:02 ` [PATCH v2 net-next 6/6] net: dsa: mv88e6xxx: Flood broadcast frames in hardware Andrew Lunn
2017-11-08  4:58 ` [PATCH v2 net-next 0/6] mv88e6xxx broadcast flooding " David Miller
2017-11-08  5:01   ` David Miller [this message]
2017-11-09 14:52     ` Vivien Didelot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171108.140138.85056790380753198.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=andrew@lunn.ch \
    --cc=f.fainelli@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=vivien.didelot@savoirfairelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).