From: David Miller <davem@davemloft.net>
To: kristian.evensen@gmail.com
Cc: bjorn@mork.no, netdev@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] qmi_wwan: Add missing skb_reset_mac_header-call
Date: Wed, 08 Nov 2017 16:12:00 +0900 (KST) [thread overview]
Message-ID: <20171108.161200.1512744535172418135.davem@davemloft.net> (raw)
In-Reply-To: <20171107124756.3029-1-kristian.evensen@gmail.com>
From: Kristian Evensen <kristian.evensen@gmail.com>
Date: Tue, 7 Nov 2017 13:47:56 +0100
> When we receive a packet on a QMI device in raw IP mode, we should call
> skb_reset_mac_header() to ensure that skb->mac_header contains a valid
> offset in the packet. While it shouldn't really matter, the packets have
> no MAC header and the interface is configured as-such, it seems certain
> parts of the network stack expects a "good" value in skb->mac_header.
>
> Without the skb_reset_mac_header() call added in this patch, for example
> shaping traffic (using tc) triggers the following oops on the first
> received packet:
...
> While the oops is for a 4.9-kernel, I was able to trigger the same oops with
> net-next as of yesterday.
>
> Signed-off-by: Kristian Evensen <kristian.evensen@gmail.com>
Applied, with Fixes: tag added, and queued up for -stable.
Thanks!
prev parent reply other threads:[~2017-11-08 7:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 12:47 [PATCH net] qmi_wwan: Add missing skb_reset_mac_header-call Kristian Evensen
[not found] ` <20171107124756.3029-1-kristian.evensen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-11-07 13:02 ` Bjørn Mork
2017-11-07 14:32 ` Kristian Evensen
2017-11-08 7:12 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171108.161200.1512744535172418135.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bjorn@mork.no \
--cc=kristian.evensen@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).