From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] qmi_wwan: Add missing skb_reset_mac_header-call Date: Wed, 08 Nov 2017 16:12:00 +0900 (KST) Message-ID: <20171108.161200.1512744535172418135.davem@davemloft.net> References: <20171107124756.3029-1-kristian.evensen@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: bjorn@mork.no, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org To: kristian.evensen@gmail.com Return-path: In-Reply-To: <20171107124756.3029-1-kristian.evensen@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Kristian Evensen Date: Tue, 7 Nov 2017 13:47:56 +0100 > When we receive a packet on a QMI device in raw IP mode, we should call > skb_reset_mac_header() to ensure that skb->mac_header contains a valid > offset in the packet. While it shouldn't really matter, the packets have > no MAC header and the interface is configured as-such, it seems certain > parts of the network stack expects a "good" value in skb->mac_header. > > Without the skb_reset_mac_header() call added in this patch, for example > shaping traffic (using tc) triggers the following oops on the first > received packet: ... > While the oops is for a 4.9-kernel, I was able to trigger the same oops with > net-next as of yesterday. > > Signed-off-by: Kristian Evensen Applied, with Fixes: tag added, and queued up for -stable. Thanks!