From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, andrew@lunn.ch
Subject: Re: [PATCH net-next 3/4] net: phy: sfp: Separate enumerations and states
Date: Wed, 8 Nov 2017 08:58:04 +0000 [thread overview]
Message-ID: <20171108085804.GP9463@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20171108034911.16382-4-f.fainelli@gmail.com>
On Tue, Nov 07, 2017 at 07:49:10PM -0800, Florian Fainelli wrote:
> Create separate enumerations for the SFP physical state (computed from GPIOs),
> device state, module state, and actual state machine. This will make it easier
> to make sure the correct states are used, and also pretty print those to help
> debugging.
The compiler does no type checking of these, so I don't see how it
makes it any "easier to make sure the correct states are used".
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up
next prev parent reply other threads:[~2017-11-08 8:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 3:49 [PATCH net-next 0/4] net: phy: sfp: Fixes and debugging improvements Florian Fainelli
2017-11-08 3:49 ` [PATCH net-next 1/4] net: phy: sfp: Do not reject soldered down modules Florian Fainelli
2017-11-08 11:15 ` Russell King - ARM Linux
2017-11-10 4:39 ` Florian Fainelli
2017-11-08 3:49 ` [PATCH net-next 2/4] net: phy: sfp: Use correct endian for sfp->id.ext.options Florian Fainelli
2017-11-08 8:56 ` Russell King - ARM Linux
2017-11-10 4:39 ` Florian Fainelli
2017-11-08 3:49 ` [PATCH net-next 3/4] net: phy: sfp: Separate enumerations and states Florian Fainelli
2017-11-08 8:58 ` Russell King - ARM Linux [this message]
2017-11-10 4:40 ` Florian Fainelli
2017-11-08 3:49 ` [PATCH net-next 4/4] net: phy: sfp: Pretty print state machine events Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171108085804.GP9463@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).