From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH net-next 3/4] net: phy: sfp: Separate enumerations and states Date: Wed, 8 Nov 2017 08:58:04 +0000 Message-ID: <20171108085804.GP9463@n2100.armlinux.org.uk> References: <20171108034911.16382-1-f.fainelli@gmail.com> <20171108034911.16382-4-f.fainelli@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, davem@davemloft.net, andrew@lunn.ch To: Florian Fainelli Return-path: Received: from pandora.armlinux.org.uk ([78.32.30.218]:50364 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750720AbdKHI6O (ORCPT ); Wed, 8 Nov 2017 03:58:14 -0500 Content-Disposition: inline In-Reply-To: <20171108034911.16382-4-f.fainelli@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Nov 07, 2017 at 07:49:10PM -0800, Florian Fainelli wrote: > Create separate enumerations for the SFP physical state (computed from GPIOs), > device state, module state, and actual state machine. This will make it easier > to make sure the correct states are used, and also pretty print those to help > debugging. The compiler does no type checking of these, so I don't see how it makes it any "easier to make sure the correct states are used". -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up According to speedtest.net: 8.21Mbps down 510kbps up