From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH net-next 0/3] netem: add nsec scheduling and slot feature Date: Wed, 8 Nov 2017 09:26:14 +0900 Message-ID: <20171108092614.11e87dea@shemminger-XPS-13-9360> References: <1510088376-5527-1-git-send-email-dave.taht@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: Dave Taht Return-path: Received: from mail-pf0-f193.google.com ([209.85.192.193]:56332 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756569AbdKHA1G (ORCPT ); Tue, 7 Nov 2017 19:27:06 -0500 Received: by mail-pf0-f193.google.com with SMTP id b85so689159pfj.13 for ; Tue, 07 Nov 2017 16:27:06 -0800 (PST) In-Reply-To: <1510088376-5527-1-git-send-email-dave.taht@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 7 Nov 2017 12:59:33 -0800 Dave Taht wrote: > This patch series converts netem away from the old "ticks" interface and > userspace API, and adds support for a new "slot" feature intended to > emulate bursty macs such as WiFi and LTE better. > > Dave Taht (3): > netem: convert to qdisc_watchdog_schedule_ns > netem: add uapi to express delay and jitter in nanosec > netem: support delivering packets in delayed time slots > > include/uapi/linux/pkt_sched.h | 10 +++ > net/sched/sch_netem.c | 144 ++++++++++++++++++++++++++++++++--------- > 2 files changed, 125 insertions(+), 29 deletions(-) > Dave, thanks for the patch. One issue is that it needs to keep binary compatibility both for kernel and iproute. That means that users of new kernel should be able to use old versions of iproute without any visible impact (and vice versa). For the kernel, that means if new attributes are not present the old attributes would be used. For iproute2 that means send both new and old versions.