From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 21/21] sunrpc: exit_net cleanup check added Date: Wed, 8 Nov 2017 10:22:05 +0900 Message-ID: <20171108102205.55aa82eb@shemminger-XPS-13-9360> References: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Anna Schumaker , Trond Myklebust , Jeff Layton , "J. Bruce Fields" To: Vasily Averin Return-path: In-Reply-To: Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On Sun, 5 Nov 2017 13:02:44 +0300 Vasily Averin wrote: > Be sure that all_clients list initialized in net_init hook was return > to initial state. > > Signed-off-by: Vasily Averin > --- > net/sunrpc/sunrpc_syms.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/net/sunrpc/sunrpc_syms.c b/net/sunrpc/sunrpc_syms.c > index c73de18..0c5a90f 100644 > --- a/net/sunrpc/sunrpc_syms.c > +++ b/net/sunrpc/sunrpc_syms.c > @@ -65,10 +65,14 @@ static __net_init int sunrpc_init_net(struct net *net) > > static __net_exit void sunrpc_exit_net(struct net *net) > { > + struct sunrpc_net *sn = net_generic(net, sunrpc_net_id); > + > rpc_pipefs_exit_net(net); > unix_gid_cache_destroy(net); > ip_map_cache_destroy(net); > rpc_proc_exit(net); > + WARN(!list_empty(&sn->all_clients), > + "net %p exit: sunrpc all_clients list is not empty\n", net); > } Don't print a kernel pointer, this is a security leak. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html