From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH net-next 2/8] rtnetlink: add rtnl_register_module Date: Wed, 8 Nov 2017 10:27:12 +0900 Message-ID: <20171108102626.195a779e@shemminger-XPS-13-9360> References: <20171106105113.20476-1-fw@strlen.de> <20171106105113.20476-3-fw@strlen.de> <20171106124454.GI3165@worktop.lehotels.local> <20171107061156.GK9424@breakpoint.cc> <20171107091004.GI3326@worktop> <20171107092458.GF3857@worktop> <20171107094751.GM9424@breakpoint.cc> <20171107145736.GN3165@worktop.lehotels.local> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Florian Westphal , netdev@vger.kernel.org To: Peter Zijlstra Return-path: Received: from mail-pf0-f194.google.com ([209.85.192.194]:46945 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752352AbdKHXeI (ORCPT ); Wed, 8 Nov 2017 18:34:08 -0500 Received: by mail-pf0-f194.google.com with SMTP id p87so2893341pfj.3 for ; Wed, 08 Nov 2017 15:34:08 -0800 (PST) In-Reply-To: <20171107145736.GN3165@worktop.lehotels.local> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 7 Nov 2017 15:57:36 +0100 Peter Zijlstra wrote: > + link = tab[msgindex]; > + rcu_assign_pointer(tab[msgindex], NULL); It is not necessary (or useful) to use rcu_assign_pointer with NULL. The rcu_assign_pointer used to special case NULL but doesn't in recent years.