From: Andrew Lunn <andrew@lunn.ch>
To: Egil Hjelmeland <privat@egil-hjelmeland.no>
Cc: Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH v3 net-next 0/5] IGMP snooping for local traffic
Date: Wed, 8 Nov 2017 16:21:01 +0100 [thread overview]
Message-ID: <20171108152101.GJ21784@lunn.ch> (raw)
In-Reply-To: <7235b67a-f248-62fe-d5e2-2fa88bcab171@egil-hjelmeland.no>
On Wed, Nov 08, 2017 at 04:11:12PM +0100, Egil Hjelmeland wrote:
> On 07. nov. 2017 18:58, Andrew Lunn wrote:
> >>Hi Andrew!
> >>
> >>When local application join multicast; the driver get 2 X .port_mdb_prepare
> >>+ 4 x .port_mdb_add for the address.
> >
> >Humm, i would expect equal numbers of those.
> >
>
> To be precise: it is (1 .port_mdb_prepare + 2 x .port_mdb_add), two times.
>
> I see that the outer repeat is due to netdev_for_each_lower_dev() in
> br_mdb_switchdev_host(). So that means we get one notification for each
> dsa-port which is joined to the bridge.
Correct. That is intentional.
> But _all_ .port_mdb_add are repeated twice as well. This is more
> interesting. I suspect that there is a missing "return 0;" in
> dsa_switch_mdb_add(), at the end of the "if
> (switchdev_trans_ph_prepare(trans)) {". Dating back to
> a1a6b7ea7f2de270a51360cc48e7c49f7a283dda.
Yes. Good catch.
Andrew
next prev parent reply other threads:[~2017-11-08 15:21 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 23:26 [PATCH v3 net-next 0/5] IGMP snooping for local traffic Andrew Lunn
2017-11-06 23:26 ` [PATCH v3 net-next 1/5] net: bridge: Rename mglist to host_joined Andrew Lunn
2017-11-08 1:31 ` Nikolay Aleksandrov
2017-11-08 1:40 ` Florian Fainelli
2017-11-06 23:26 ` [PATCH v3 net-next 2/5] net: bridge: Send notification when host join/leaves a group Andrew Lunn
2017-11-08 1:39 ` Nikolay Aleksandrov
2017-11-08 1:41 ` Florian Fainelli
2017-11-06 23:26 ` [PATCH v3 net-next 3/5] net: bridge: Add/del switchdev object on host join/leave Andrew Lunn
2017-11-08 1:48 ` Nikolay Aleksandrov
2017-11-06 23:26 ` [PATCH v3 net-next 4/5] net: dsa: slave: Handle switchdev host mdb add/del Andrew Lunn
2017-11-06 23:26 ` [PATCH v3 net-next 5/5] net: dsa: switch: Don't add CPU port to an mdb by default Andrew Lunn
2017-11-07 10:12 ` Sergei Shtylyov
2017-11-07 1:01 ` [PATCH v3 net-next 0/5] IGMP snooping for local traffic Stephen Hemminger
2017-11-07 17:03 ` Vivien Didelot
2017-11-07 17:42 ` Andrew Lunn
2017-11-07 18:10 ` Florian Fainelli
2017-11-07 18:16 ` Vivien Didelot
2017-11-07 21:01 ` Andrew Lunn
2017-11-07 21:18 ` Florian Fainelli
2017-11-07 22:17 ` Andrew Lunn
2017-11-07 22:37 ` Vivien Didelot
2017-11-07 23:17 ` Andrew Lunn
2017-11-08 0:41 ` Florian Fainelli
2017-11-09 18:41 ` Florian Fainelli
2017-11-09 19:30 ` Andrew Lunn
2017-11-09 19:38 ` Florian Fainelli
2017-11-09 20:21 ` Andrew Lunn
2017-11-09 20:35 ` Florian Fainelli
2017-11-09 21:13 ` Andrew Lunn
2017-11-09 21:40 ` Ido Schimmel
2017-11-07 17:34 ` Egil Hjelmeland
2017-11-07 17:58 ` Andrew Lunn
2017-11-08 15:11 ` Egil Hjelmeland
2017-11-08 15:21 ` Andrew Lunn [this message]
2017-11-08 15:53 ` Vivien Didelot
2017-11-09 2:30 ` David Miller
2017-11-09 2:47 ` David Miller
2017-11-09 14:44 ` Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171108152101.GJ21784@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=privat@egil-hjelmeland.no \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).