From: David Miller <davem@davemloft.net>
To: xiyou.wangcong@gmail.com
Cc: netdev@vger.kernel.org, lucasb@mojatatu.com, jhs@mojatatu.com,
jiri@resnulli.us
Subject: Re: [Patch net 00/13] net_sched: close the race between call_rcu() and cleanup_net()
Date: Thu, 09 Nov 2017 11:26:07 +0900 (KST) [thread overview]
Message-ID: <20171109.112607.6392736117383202.davem@davemloft.net> (raw)
In-Reply-To: <20171106214730.24421-1-xiyou.wangcong@gmail.com>
From: Cong Wang <xiyou.wangcong@gmail.com>
Date: Mon, 6 Nov 2017 13:47:17 -0800
> This patchset tries to fix the race between call_rcu() and
> cleanup_net() again. Without holding the netns refcnt the
> tc_action_net_exit() in netns workqueue could be called before
> filter destroy works in tc filter workqueue. This patchset
> moves the netns refcnt from tc actions to tcf_exts, without
> breaking per-netns tc actions.
>
> Patch 1 reverts the previous fix, patch 2 introduces two new
> API's to help to address the bug and the rest patches switch
> to the new API's. Please see each patch for details.
>
> I was not able to reproduce this bug, but now after adding
> some delay in filter destroy work I manage to trigger the
> crash. After this patchset, the crash is not reproducible
> any more and the debugging printk's show the order is expected
> too.
>
> Fixes: ddf97ccdd7cb ("net_sched: add network namespace support for tc actions")
> Reported-by: Lucas Bates <lucasb@mojatatu.com>
> Cc: Lucas Bates <lucasb@mojatatu.com>
> Cc: Jamal Hadi Salim <jhs@mojatatu.com>
> Cc: Jiri Pirko <jiri@resnulli.us>
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
I have to say this was a lot of churn so late in the release
cycle.... but I ended up pulling anyways.
I cannot guarantee that I will be able to push this to Linus
in time for 4.14-final.
Thanks.
next prev parent reply other threads:[~2017-11-09 2:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 21:47 [Patch net 00/13] net_sched: close the race between call_rcu() and cleanup_net() Cong Wang
2017-11-06 21:47 ` [Patch net 01/13] Revert "net_sched: hold netns refcnt for each action" Cong Wang
2017-11-06 21:47 ` [Patch net 02/13] net_sched: introduce tcf_exts_get_net() and tcf_exts_put_net() Cong Wang
2017-11-06 21:47 ` [Patch net 03/13] cls_basic: use tcf_exts_get_net() before call_rcu() Cong Wang
2017-11-06 21:47 ` [Patch net 04/13] cls_bpf: " Cong Wang
2017-11-06 21:47 ` [Patch net 05/13] cls_cgroup: " Cong Wang
2017-11-09 22:31 ` Roman Mashak
2017-11-09 23:52 ` Cong Wang
2017-11-06 21:47 ` [Patch net 06/13] cls_flow: " Cong Wang
2017-11-06 21:47 ` [Patch net 07/13] cls_flower: " Cong Wang
2017-11-06 21:47 ` [Patch net 08/13] cls_fw: " Cong Wang
2017-11-06 21:47 ` [Patch net 09/13] cls_matchall: " Cong Wang
2017-11-06 21:47 ` [Patch net 10/13] cls_route: " Cong Wang
2017-11-06 21:47 ` [Patch net 11/13] cls_rsvp: " Cong Wang
2017-11-06 21:47 ` [Patch net 12/13] cls_tcindex: " Cong Wang
2017-11-06 21:47 ` [Patch net 13/13] cls_u32: " Cong Wang
2017-11-09 2:26 ` David Miller [this message]
2017-11-09 2:32 ` [Patch net 00/13] net_sched: close the race between call_rcu() and cleanup_net() Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171109.112607.6392736117383202.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=lucasb@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).