From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: David Laight <David.Laight@ACULAB.COM>,
'Sagi Grimberg' <sagi@grimberg.me>,
Thomas Gleixner <tglx@linutronix.de>,
Jes Sorensen <jsorensen@fb.com>,
Tariq Toukan <tariqt@mellanox.com>,
Saeed Mahameed <saeedm@dev.mellanox.co.il>,
Networking <netdev@vger.kernel.org>,
Leon Romanovsky <leonro@mellanox.com>,
Saeed Mahameed <saeedm@mellanox.com>,
Kernel Team <kernel-team@fb.com>, Christoph Hellwig <hch@lst.de>
Subject: Re: mlx5 broken affinity
Date: Thu, 9 Nov 2017 11:09:48 +0100 [thread overview]
Message-ID: <20171109100948.GA18320@lst.de> (raw)
In-Reply-To: <98ba68ee-a21c-e509-d4c3-e21c2ec138f8@kernel.dk>
On Wed, Nov 08, 2017 at 09:13:59AM -0700, Jens Axboe wrote:
> There are numerous valid reasons to be able to set the affinity, for
> both nics and block drivers. It's great that the kernel has a predefined
> layout that works well, but users do need the flexibility to be able to
> reconfigure affinities, to suit their needs.
Managed interrupts are about more than just setting affinities - they
bind a a vector (which means a queue) to a specific cpu or set of cpus.
This is extremely useful to deal with hotplug issues and also makes
life a lot easier in general.
> But that particular case is completely orthogonal to whether or not we
> should allow the user to reconfigure. The answer to that is clearly YES,
> and we should ensure that this is possible.
And why is the answer yes? If the anser is YES it means we need explicit
boilerplate code to deal with cpu hotplug in every driver not using
managed interrupts (even if optionally), so it is a non-trivial tradeoff.
next prev parent reply other threads:[~2017-11-09 10:09 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-01 16:19 mlx5 broken affinity Jes Sorensen
2017-11-01 17:21 ` Sagi Grimberg
2017-11-01 18:20 ` Jes Sorensen
2017-11-01 22:41 ` Saeed Mahameed
2017-11-01 23:02 ` Jes Sorensen
2017-11-02 8:28 ` Tariq Toukan
2017-11-02 10:08 ` Sagi Grimberg
2017-11-02 12:13 ` Andrew Lunn
2017-11-02 14:48 ` Jes Sorensen
2017-11-02 16:14 ` Sagi Grimberg
2017-11-02 17:13 ` Jes Sorensen
2017-11-02 18:10 ` Thomas Gleixner
2017-11-05 8:36 ` Sagi Grimberg
2017-11-07 15:07 ` Thomas Gleixner
2017-11-08 7:27 ` Sagi Grimberg
2017-11-08 12:21 ` David Laight
2017-11-08 16:13 ` Jens Axboe
2017-11-09 10:09 ` Christoph Hellwig [this message]
2017-11-09 15:18 ` Jens Axboe
2017-11-09 15:08 ` Saeed Mahameed
2017-11-09 15:40 ` Sagi Grimberg
2017-11-08 16:19 ` Jes Sorensen
2017-11-08 17:33 ` Thomas Gleixner
2017-11-09 10:50 ` Sagi Grimberg
2017-11-09 14:19 ` Thomas Gleixner
2017-11-09 15:21 ` Jens Axboe
2017-11-09 17:03 ` Thomas Gleixner
2017-11-09 20:11 ` Jens Axboe
2017-11-09 21:23 ` Thomas Gleixner
2017-11-09 21:30 ` Jens Axboe
2017-11-09 21:42 ` [RFD] Managed interrupt affinities [ Was: mlx5 broken affinity ] Thomas Gleixner
2017-11-10 5:56 ` Saeed Mahameed
2017-11-10 13:03 ` Thomas Gleixner
2017-11-13 19:20 ` Sagi Grimberg
2017-11-13 20:51 ` Thomas Gleixner
2017-11-13 21:13 ` Sagi Grimberg
2017-11-13 21:33 ` Thomas Gleixner
2017-11-13 21:49 ` Sagi Grimberg
2017-11-14 10:15 ` Thomas Gleixner
2017-11-09 16:01 ` mlx5 broken affinity Sagi Grimberg
2017-11-09 16:09 ` Jens Axboe
2017-11-09 17:07 ` Thomas Gleixner
2017-11-09 20:12 ` Jens Axboe
2017-11-09 21:25 ` Thomas Gleixner
2017-11-09 15:19 ` Jens Axboe
2017-11-09 22:03 ` Jes Sorensen
2017-11-02 7:57 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171109100948.GA18320@lst.de \
--to=hch@lst.de \
--cc=David.Laight@ACULAB.COM \
--cc=axboe@kernel.dk \
--cc=jsorensen@fb.com \
--cc=kernel-team@fb.com \
--cc=leonro@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@dev.mellanox.co.il \
--cc=saeedm@mellanox.com \
--cc=sagi@grimberg.me \
--cc=tariqt@mellanox.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).