From: Andrew Lunn <andrew@lunn.ch>
To: Roman Yeryomin <roman@advem.lv>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
"Vivien Didelot" <vivien.didelot@savoirfairelinux.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
netdev@vger.kernel.org, "Antti Seppälä" <a.seppala@gmail.com>,
"Colin Leitner" <colin.leitner@googlemail.com>,
"Gabor Juhos" <juhosg@openwrt.org>
Subject: Re: [PATCH 4/4] RFC: net: dsa: realtek-smi: Add Realtek SMI driver
Date: Thu, 9 Nov 2017 16:38:57 +0100 [thread overview]
Message-ID: <20171109153857.GA13277@lunn.ch> (raw)
In-Reply-To: <789e794b57140202137de8656b97d336@advem.lv>
> >>Unless switchdev could be expanded to support other functions beyond
> >>VLAN,
> >>like port rate control, ACL, HW NAT (no switchdev L3 offload doesn't fit
> >>this), etc.
> >
> >Switchdev allows offloading of TC. So port rate control would be
> >implemented via TC.
>
> That's interesting. Are there any examples implemented?
Mellonex have a few for there TOR switches.
The SF2 has TC mirred implemented. I could also implement this for
Marvell without too much effort. No DSA switch yet implements port
rate control via TC. But TC would be the correct interface to use.
> >By ACL do you mean filtering MAC addresses?
>
> Not only. Usually ACL means defining action with rules matching MAC/IP
> address, physical or TCP/IP port, VID, Ethertype or even custom bytes.
> And actions could be drop, assign rate, change VID/priority, force L3
> offload or mirroring, redirect/copy to CPU port.
So this means mapping iptable rules to the switches TCAM. Pablo has
said he is working on this, but there has not been any code posted
yet.
> But the question how exactly it will be done?
The whole idea with switchdev is that your switch interfaces look like
a bunch of linux interfaces, and you configure them just as normal
Linux interface. You setup NAT as you would normally setup NAT. It
then gets pushed down to the hardware. You setup TC rules or ip table
rules on the interface, and they get pushed down to the hardware.
It is just Linux networking as normal. Think of the switch as an
accelerator for what Linux networking can already do.
Andrew
next prev parent reply other threads:[~2017-11-09 15:39 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-05 23:19 [PATCH 0/4] RFC: Realtek 83xx SMI driver core Linus Walleij
2017-11-05 23:19 ` [PATCH 1/4] RFC: net/dsa: Allow DSA PHYs to define link IRQs Linus Walleij
2017-11-05 23:19 ` [PATCH 2/4] RFC: net: phy: realtek: Support RTL8366RB variant Linus Walleij
2017-11-05 23:19 ` [PATCH 3/4] RFC: net: dsa: Add bindings for Realtek SMI DSAs Linus Walleij
2017-11-05 23:48 ` Andrew Lunn
[not found] ` <20171105234831.GA24822-g2DYL2Zd6BY@public.gmane.org>
2017-11-29 12:24 ` Linus Walleij
2017-11-29 15:56 ` Andrew Lunn
2017-11-29 21:28 ` Linus Walleij
[not found] ` <CACRpkdZVXgFMiHpyUqw7ONYDcq6Htn3rTMRaBJkzd6T3WtX36A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-11-29 21:48 ` Florian Fainelli
2017-11-29 21:56 ` Andrew Lunn
[not found] ` <20171129215659.GC1706-g2DYL2Zd6BY@public.gmane.org>
2017-11-29 23:19 ` Linus Walleij
2017-11-29 23:26 ` Florian Fainelli
[not found] ` <f9bfa1e1-7f05-1e2b-6663-09d4d3bf6a12-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-11-29 23:36 ` Andrew Lunn
2017-12-02 12:56 ` Linus Walleij
[not found] ` <CACRpkdYoMVNh8eaTnaDQ59bsh4bC88biLaYSXyhnc4W83PMWzA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-12-04 22:50 ` Andrew Lunn
2017-11-05 23:19 ` [PATCH 4/4] RFC: net: dsa: realtek-smi: Add Realtek SMI driver Linus Walleij
2017-11-05 23:59 ` Andrew Lunn
2017-11-06 8:25 ` Linus Walleij
2017-11-09 12:49 ` Roman Yeryomin
2017-11-09 13:24 ` Andrew Lunn
2017-11-09 15:11 ` Roman Yeryomin
2017-11-09 15:38 ` Andrew Lunn [this message]
2017-11-09 17:21 ` Roman Yeryomin
2017-11-09 17:24 ` Andrew Lunn
2017-11-09 18:08 ` Florian Fainelli
2017-11-10 8:16 ` Linus Walleij
2017-11-10 12:05 ` Roman Yeryomin
2017-11-10 12:02 ` Roman Yeryomin
2017-11-10 13:51 ` Andrew Lunn
2017-11-10 12:17 ` Egil Hjelmeland
2017-11-10 14:01 ` Andrew Lunn
2018-04-02 16:10 ` [PATCH 0/4] RFC: Realtek 83xx SMI driver core Carl-Daniel Hailfinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171109153857.GA13277@lunn.ch \
--to=andrew@lunn.ch \
--cc=a.seppala@gmail.com \
--cc=colin.leitner@googlemail.com \
--cc=f.fainelli@gmail.com \
--cc=juhosg@openwrt.org \
--cc=linus.walleij@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=roman@advem.lv \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).